Skip to content

fix: preserve sign when rounding the smallest subnormal #15667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 1 commit into from
Sep 30, 2026
Merged

fix: preserve sign when rounding the smallest subnormal #15667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/math/base/special/round2/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function round2( x ) {

// If provided the smallest subnormal, no rounding possible:
if ( p === MIN_EXP_SUBNORMAL ) {
return x;
return sign * x;
}

// Find the previous and next integer powers:
Expand Down
6 changes: 6 additions & 0 deletions lib/node_modules/@stdlib/math/base/special/round2/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@ tape( 'the function returns the minimum double-precision floating-point value if
t.end();
});

tape( 'the function returns the negative minimum double-precision floating-point value if provided the negative minimum double-precision floating-point value', function test( t ) {
var v = round2( -SMALLEST_SUBNORMAL );
t.strictEqual( v, -SMALLEST_SUBNORMAL, 'returns negative smallest subnormal' );
t.end();
});

tape( 'the function overflows if provided a sufficiently large value', function test( t ) {
var x;
var v;
Expand Down
Loading