Repository navigation
test: migrate stats/strided/sstdev to ULP-based assertions - #15665
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QGSqj3XSMadv5etJbf1wZ --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
September 30, 2026 05:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/strided/sstdevfrom relative tolerance testing to ULP difference testing, replacing the computeddelta/tolcomparisons with@stdlib/number/float32/base/assert/is-almost-same-value.Concretely, in each of
test/test.sstdev.js,test/test.sstdev.native.js,test/test.ndarray.js, andtest/test.ndarray.native.js, the followingis replaced by
along with adding the
@stdlib/number/float32/base/assert/is-almost-same-valuerequire and dropping the now-unused@stdlib/math/base/special/absand@stdlib/constants/float32/epsrequires and thedelta/toldeclarations.As this package operates on single-precision floating-point numbers, the tests use the single-precision assertion utility (
isAlmostSameValuef), matching the convention already established by the sibling packagestats/strided/sstdevpn, whose test files are otherwise line-for-line identical to this package's.ULP bound
test/test.sstdev.js11test/test.sstdev.native.js11test/test.ndarray.js11test/test.ndarray.native.js11The bound was tightened empirically rather than guessed. Starting from a high value and lowering it,
1is the smallest integer for which the assertions pass; at0all four files fail, as the returned value is not bit-identical to the expected value:So
1is the tightest possible non-exact bound here. The native add-on was compiled locally, so the1bound in the*.native.jsfiles is measured rather than mirrored: the JavaScript and C implementations return the same value for this case, and both are exactly one ULP from the expected value. This is also consistent with the prior state of this package, which applied an identical1.0 * EPStolerance in all four files.The full test suite was run twice at the final value to confirm the result is stable (no FMA/arch-dependent variation); both runs report the same
77passing assertions and0failures.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only the four test files are modified; no source, documentation, benchmark, or fixture files are touched.
test/test.jscontains no tolerance-based assertions and is left unchanged.Verification performed:
make test TESTS_FILTER=".*/stats/strided/sstdev/.*"—77passing,0failing, with the native add-on built so thattest.sstdev.native.jsandtest.ndarray.native.jsactually execute rather than skip. Run twice, with identical results.etc/eslint/.eslintrc.tests.js(the configurationmake lint-javascript-testsapplies to test files) — clean,0problems across all four files.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended task. It studied the migration idiom from previously merged conversions in the same family, applied the mechanical substitution to the four test files, and determined the
1ULP bound by measuring the actual ULP distance for both the JavaScript and C implementations and confirming that0fails while1passes, then re-running the suite to confirm the result is deterministic.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_019QGSqj3XSMadv5etJbf1wZ
Generated by Claude Code