Repository navigation
docs: update descriptions - #15653
Merged
Merged
Conversation
Propagates fix from 8ae6d64 ("docs: update description") to sibling packages carrying the same unbackticked `NaN` in TypeScript declaration descriptions. Commits 8ae6d64, 02bbe40, and 5c4b613 rendered `NaN` as inline code in JSDoc description lines within `docs/types/index.d.ts`. These 22 lines across eight files were the remaining plain occurrences of that phrasing in the file type, against 873 already using the inline code form. The namespace entries in `stats/docs/types/index.d.ts` and `stats/base/ndarray/docs/types/index.d.ts` are updated together with the member package declarations they are generated from, so nightly regeneration of the namespace declarations remains a no-op. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VYzCUqHiEst6mVYhP72gSS
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Sep 30, 2026
NaN in stats TypeScript declarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagating fixes merged to
developbetween 2026-09-28 13:09 UTC and 2026-09-29 13:09 UTC (e0ab571bc^..32c09fd47, 34 commits) to sibling packages.No associated issue.
Description
Inline code for
NaNin TypeScript declaration descriptions8ae6d6499,02bbe4011, and5c4b61336renderedNaNas inline code in JSDoc description lines withindocs/types/index.d.ts, each covering the packages those commits happened to touch. The 22 lines changed here are the remaining plain occurrences of that phrasing in the file type repo-wide, against 873 already using the inline code form. Target packages:stats(namespace declarations,nanminByandnanrangeByentries)stats/base/ndarray(namespace declarations,dnanrange,dnanrangeabs, andsnanmidrangeentries)stats/base/ndarray/dnanrangestats/base/ndarray/dnanrangeabsstats/base/ndarray/snanmidrangestats/incr/nanmmeanstdevstats/nanmin-bystats/nanrange-byThe namespace declaration files are regenerated from their member packages' declarations, so each namespace entry is updated together with the member package it derives from and regeneration remains a no-op.
Related Issues
No.
Questions
stats/base/ndarray/sdsnanmeanorswas deliberately left out (see below). It is the one package where this phrasing is plain across every artifact rather than only in the declarations, so finishing it is a per-package pass rather than a propagation. Say the word and it can ride along.Other
Validation
ignoring NaN valuesacross alldocs/types/index.d.tsunderlib/node_modules/@stdlib. 24 hits, all understats; 22 advanced.@example, and is not an identifier or type name. BareNaNinside example code in the same files is untouched.stats/docs/types/index.d.tsandstats/base/ndarray/docs/types/index.d.tsare rewritten by the nightly namespace-declarations job from each member package's trailing JSDoc block. All six namespace lines changed here map to member package lines also changed here, so the job's output is unchanged.Infinity,null,undefined,true,false) as inline code in declaration prose, and that the replacement is a pure two-character insertion preserving punctuation at every site.max-lenfor declarations is{ code: 1000, ignorePattern: '^import |// |/?\* ' }andstdlib/jsdoc-maximum-line-lengthis off, so the added characters carry no line-length risk. No lint rule enforces this convention either way. Repo dev dependencies are not installed in this environment, so the declaration lint was not run locally.Deliberately excluded
stats/base/ndarray/sdsnanmeanors(2 lines). The second validation pass rejected it: that package is uniformly plain in its README,repl.txt,libJSDoc,package.json, and the generated namespace table of contents, so changing only its declarations would make them the lone outlier. Dropped under the "both passes must confirm" rule.docs/repl.txtlines instats/nanmin-by,stats/nanrange-by,stats/base/ndarray/dnanrange, andstats/base/ndarray/dnanrangeabs. REPL help wraps at 76 columns, so adding inline code there requires re-wrapping the surrounding paragraph — a reflow beyond the scope of this propagation.package.jsondescriptions, which use the plain form by settled convention (318 plain vs 2 backticked).consensusOrderchange from100ca4c8dand32c09fd47tondarray/base/kernels/generic/unary-strided1d/unblocked(9 sites). chore: clean-up #15652 corrects the call form at the binary and ternary sites and raises an open question about the intended form; extending it to a third kernel family should wait on that.[inout]to[out]correction from8c8948623. Ten textual matches underblas/ext, none valid:dxpyanddxdycomputey[i] = x[i] + y[i]andy[i] = x[i] / y[i], so their second ndarray is genuinely read-modify-write, unlike the write-only output indwxsa.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code as an automated pass propagating fixes merged to
developin the stated window to sibling packages. Candidate sites came from a pattern search over the source commits, then two independent validation passes and a style pass reviewed every site; sites the two validation passes disagreed on were dropped. No human has audited these changes yet, so the PR is opened as a draft.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01VYzCUqHiEst6mVYhP72gSS
Generated by Claude Code