Repository navigation
chore: update keywords - #15624
Merged
Merged
chore: update keywords#15624
Conversation
…l-less-than` Replaces the `less than` and `lt` keywords with `less-than`, matching the base package `blas/ext/base/gfill-less-than` and the sibling `blas/ext/base/ndarray/gfill-greater-than`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KiNTzHsWDjMc7CagsFEcpz
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Sep 28, 2026
blas/ext/base/ndarray/gfill-less-than
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-09-27 14:57 -0700 (e1724483) and 2026-09-28 03:38 -0700 (41f72749).Description
This pull request:
blas/ext/base/ndarray/gfill-less-than/package.jsonused"less than"and a stray"lt"inkeywords; neither matches the base package or thegfill-greater-thansibling. Collapsed both into"less-than"to match convention.Review window: 38 first-parent commits, 420 files. The batch breaks down as follows, and everything below was reviewed and found clean:
blas/ext/base/ndarray/{dany,sany,dnone,snone,dxsa,sxsa,daxpb,saxpb,dwxsa,done-to,dzero-to}andstats/base/ndarray/{smaxabssorted,dminsorted,smediansorted}. Precision tokens (double/Float64Arrayvsfloat/Float32Array), header guards, exported symbol names, N-API argument counts,manifest.jsondeps andbinding.gyp/include.gypi/src/Makefileall match their own package; nod↔scrossover.blas/ext/base/gpad-edge,blas/ext/base/dleft-pad-edge,blas/ext/base/gindex-of-greater-than-sorted,blas/ext/base/ndarray/gfill-less-than,math/base/special/cothf,fft/base/fftpack/ndarray/float64/sinqi. Every documented numeric example was recomputed by hand, and the pad/binary-search implementations were brute-forced against independent references across negative, zero and non-unit strides plus view offsets.1.0*EPS→ 0 ULP instats/base/dists/logistic/mode,2.0*EPS→ 0 ULP instats/base/dists/binomial/variance).jqnull-guard inprocess_metadata.yml(d7c4ea0) and the missing-test-directory skip inrun_tests_coverage/run(1e56ff8).Related Issues
No.
Questions
No.
Other
Validation. Four independent reviewers ran over the window: two style/convention audits comparing each changed or new package against an established reference package of comparable complexity and checking it against
docs/style-guides, and two bug scans (one restricted to the diff text, one permitted to read callees in order to reason about the introduced logic). Coverage included precision-token and sibling cross-comparison across the C addon backfill, hand-recomputation of every documented numeric example, brute-force differential testing of the new pad and binary-search routines over negative/zero/non-unit strides and view offsets, C memory safety and build wiring, the ULP migrations, and the two CI/shell changes.Findings were merged and de-duplicated, then anything that could not be independently re-verified by re-reading the diff, lacked a concrete fix, or fell outside the window was dropped. One issue survived. The
"less than"/"lt"keywords are the only occurrences of either string in anypackage.jsonin the repo;"less-than"is used by three others, including the base package this one wraps.Deliberately excluded: anything requiring interpretation or a judgment call. Two such items were raised and dropped —
smaxabssorted/benchmark/benchmark.native.jsnaming its importisnanwheresmediansortedusesisnanf(identical behavior), andsmaxabssorteddoc comments omitting "sorted" where its siblings include it. Also out of scope: thestats/strided/*callees returningX[0]while ignoringoffsetXwhenN == 1 || strideX == 0, which is pre-existing and untouched by this window.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by Claude Code running as a scheduled review of commits merged to
developin the preceding 24 hours. The review, the filtering of findings, and the one-line fix were all authored by Claude Code. Opened as a draft for maintainer audit before promotion.🤖 Generated with Claude Code
https://claude.ai/code/session_01KiNTzHsWDjMc7CagsFEcpz
Generated by Claude Code