Repository navigation
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage ReportNo coverage information available. |
|
Thank you for your contribution and congratulations on your first PR! |
|
thanks ! |
Resolves a part of #11352.
Description
This PR migrates the numerical fixture checks for
stats/base/dists/exponential/mgffrom relative-tolerance comparisons to ULP assertions intest.factory.js,test.mgf.js, andtest.native.js.The ULP thresholds were determined by sweeping the small, medium, and large fixture sets and selecting the minimum passing bounds. The native addon was built locally, and the JavaScript main export, factory, and native implementation were checked. Their maximum ULP differences matched:
The package tests passed twice with these bounds.
Related Issues
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only the three test files are changed.
Verification:
make test TESTS_FILTER=".*/stats/base/dists/exponential/mgf/.*"passed twice (3015 assertions each run).Checklist
AI Assistance