Skip to content

feat: add C implementation for blas/ext/base/ndarray/dwxsa - #15596

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
himayurjogade:feature/blas-ext-base-ndarray-dwxsa-c
Sep 28, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
himayurjogade:feature/blas-ext-base-ndarray-dwxsa-c

Conversation

@himayurjogade

@himayurjogade himayurjogade commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Part of #14819.

Description

What is the purpose of this pull request?

This pull request:

  • adds a C implementation for @stdlib/blas/ext/base/ndarray/dwxsa.
  • adds a Node-API addon and tryRequire dispatcher with a fallback to the
    JavaScript implementation when the native addon is unavailable.
  • adds JavaScript and C benchmarks, along with a C example.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

AI assistance was used for reviewing changes and researching repository conventions.

I've checked each file and verified the result locally: the addon compiles without warnings, both the JavaScript and native test suites pass with the native results matching the JavaScript implementation, the C example and benchmarks run correctly, and ESLint reports no errors. Happy to make any adjustments.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@himayurjogade
himayurjogade requested a review from a team September 27, 2026 18:28
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Sep 27, 2026
@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. and removed Needs Review A pull request which needs code review. labels Sep 28, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @himayurjogade, for opening such a clean PR!

@kgryte
kgryte merged commit 415ca7f into stdlib-js:develop Sep 28, 2026
135 checks passed
@kgryte

kgryte commented Sep 28, 2026

Copy link
Copy Markdown
Member

Thank you for your contribution and congratulations on your first PR!

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@himayurjogade

Copy link
Copy Markdown
Contributor Author

Thank you, @kgryte! Glad it landed cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants