Skip to content

build: skip packages without a test directory #15591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 3 commits into from
Sep 27, 2026
Merged

build: skip packages without a test directory #15591

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
408eab0
build(workflows): skip test-less packages in `run_tests_coverage`
claude Sep 27, 2026
381e975
style(workflows): simplify skip-comment wording in `run_tests_coverage`
claude Sep 27, 2026
6ff9cb8
style(workflows): use plain-text warning in `run_tests_coverage`
claude Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions .github/workflows/scripts/run_tests_coverage/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,17 @@ main() {
exit 0
fi

mkdir -p artifacts
coverage=''
for package in ${directories}; do
# For each package, extract coverage values from the respective coverage report:
pkg=$(echo "$package" | sed -E 's/^.*stdlib\///')

# Skip packages which do not have a test directory, as `make test-javascript-cov` fails when a `TESTS_FILTER` matches zero files:
if [ ! -d "lib/node_modules/@stdlib/${pkg}/test" ]; then
echo "WARNING: No test directory found for package '${pkg}'. Skipping..." >&2
continue
fi

if [ -f "lib/node_modules/@stdlib/${pkg}/binding.gyp" ]; then
NODE_ADDONS_PATTERN="${pkg}" make install-node-addons
fi
Expand Down Expand Up @@ -195,10 +200,14 @@ main() {
rm -rf reports/coverage/lcov-report/*
done

# Format coverage as Markdown table row:
table_body=$(echo "$coverage" | sed -e 's/,/|/g; s/"/ /g; s/\[/|/g; s/\]/|/g')
table_header="| Package | Statements | Branches | Functions | Lines |\n| --------- | ------------ | ---------- | ----------- | ----- |"
table="${table_header}${table_body}"
# Format coverage as a Markdown table row, unless every changed package was skipped (e.g., no package had a test directory):
if [ -z "$coverage" ]; then
table=''
else
table_body=$(echo "$coverage" | sed -e 's/,/|/g; s/"/ /g; s/\[/|/g; s/\]/|/g')
table_header="| Package | Statements | Branches | Functions | Lines |\n| --------- | ------------ | ---------- | ----------- | ----- |"
table="${table_header}${table_body}"
fi

echo "table=$table" >> "$GITHUB_OUTPUT"

Expand Down
Loading