Repository navigation
test: tighten fixture tolerances in stats/base/dists/lognormal/pdf - #15577
Merged
kgryte merged 1 commit intoSep 27, 2026
Merged
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
stdlib-bot
added
Statistics
anandkaranubc
added
METR
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
added
review: 5
and removed
Needs Review
kgryte
approved these changes
Sep 27, 2026
kgryte
left a comment
kgryte
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the follow-up, @anandkaranubc!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#1377
Description
This pull request:
stats/base/dists/lognormal/pdffrom 800/1489/305 ULP to 4 ULP intest/test.pdf.js,test/test.factory.js, andtest/test.native.js. The old tolerances matched the error of the previous implementation; after fix: avoid overflow and duplicate computation #14446 changed the formula, the measured maximum error against the same fixtures is 4 ULP.Related Issues
This pull request has the following related issues:
stats/base/dists/lognormal/pdfmetr-issue-tracker#1377Questions
No.
Other
Measured maximum error per fixture (JS
main,factory, and a freshly built native add-on): 4 ULP forpositive_location.json,negative_location.json, andlarge_variance.json.One caveat for the native bound: the 4 ULP figure holds wherever the compiler does not contract floating-point expressions — x86-64 CI (no FMA in the baseline ISA) and any build with
-ffp-contract=off. On arm64 with default flags, FMA contraction shifts the compiledlnby 1 ULP at onepositive_locationinput, whichexp( z )atz ≈ -386amplifies to ~1986 ULP in the pdf. This is a property of the toolchain, not of this package (the previous 800 ULP bound already failed that case on such builds); local arm64 runs reproduce the 4 ULP bound withCFLAGS="-ffp-contract=off" make install-node-addons.Checklist
AI Assistance
@stdlib-js/reviewers