Skip to content

test: migrate math/base/tools/continued-fraction to ULP-based assertions #15573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 3 commits into from
Sep 27, 2026
Merged

test: migrate math/base/tools/continued-fraction to ULP-based assertions #15573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
884ba64
test: migrate `math/base/tools/continued-fraction` to ULP-based asser…
claude Sep 26, 2026
005b44b
style: disable lint rule
kgryte Sep 27, 2026
e7d71fd
style: disable lint rule
kgryte Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@

'use strict';

/* eslint-disable no-restricted-syntax */
/* eslint-disable no-restricted-syntax, n/no-unsupported-features/es-syntax */

// MODULES //

var tape = require( 'tape' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var continuedFraction = require( './../../lib/' );


Expand All @@ -34,7 +34,7 @@ tape( 'if provided a generator function, the function evaluates the correspondin
var expected = 0.5819767068693261;
var actual = continuedFraction( generator() );

t.ok( abs( actual - expected ) < 1e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' );
t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' );
t.end();

function* generator() {
Expand All @@ -52,14 +52,14 @@ tape( 'if provided a generator function, the function evaluates the correspondin
'keep': true
});

t.ok( abs( actual - expected ) < 1e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' );
t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' );

actual = continuedFraction( generator2(), {
'keep': true
});
expected = 1.525135276160983;

t.ok( abs( actual - expected ) < 1e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' );
t.strictEqual( isAlmostSameValue( actual, expected, 13 ), true, 'returns expected value' );

t.end();

Expand Down
15 changes: 7 additions & 8 deletions lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
var tape = require( 'tape' );
var proxyquire = require( 'proxyquire' );
var detectGeneratorSupport = require( '@stdlib/assert/has-generator-support' );
var abs = require( '@stdlib/math/base/special/abs' );
var EPS = require( '@stdlib/constants/float64/eps' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var continuedFraction = require( './../lib' );
var continuedFractionBasic = proxyquire( './../lib', {
'detect-generator-support': function getFalse() { return false; }
Expand Down Expand Up @@ -55,7 +54,7 @@ tape( 'by default, the function evaluates the continued fraction without the lea
var expected = 0.5819767068693261;
var actual = continuedFraction( generator() );

t.ok( abs( actual - expected ) < EPS, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' );
t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' );
t.end();

function generator() {
Expand All @@ -74,7 +73,7 @@ tape( 'by default, the function evaluates the continued fraction without the lea
var expected = 0.5819767068693261;
var actual = continuedFractionBasic( generator() );

t.ok( abs( actual - expected ) < EPS, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' );
t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' );
t.end();

function generator() {
Expand All @@ -94,14 +93,14 @@ tape( 'if keep option is true, the function evaluates the continued fraction wit
'keep': true
});

t.ok( abs( actual - expected ) < EPS, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' );
t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' );

actual = continuedFraction( generator2(), {
'keep': true
});
expected = 1.525135276160983;

t.ok( abs( actual - expected ) < 1e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' );
t.strictEqual( isAlmostSameValue( actual, expected, 13 ), true, 'returns expected value' );
t.end();

// Continued fraction for (I_1(2))/(I_0(2)), see http://mathworld.wolfram.com/ContinuedFraction.html:
Expand Down Expand Up @@ -132,14 +131,14 @@ tape( 'if keep option is true, the function evaluates the continued fraction wit
'keep': true
});

t.ok( abs( actual - expected ) < EPS, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' );
t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' );

actual = continuedFractionBasic( generator2(), {
'keep': true
});
expected = 1.525135276160983;

t.ok( abs( actual - expected ) < 1e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' );
t.strictEqual( isAlmostSameValue( actual, expected, 13 ), true, 'returns expected value' );
t.end();

// Continued fraction for (I_1(2))/(I_0(2)), see http://mathworld.wolfram.com/ContinuedFraction.html:
Expand Down
Loading