Repository navigation
chore: clean-up - #15565
chore: clean-up#15565
Conversation
The CLI usage text documents `-i` and `-w` as short forms of `--indent` and `--max-width`, but neither was registered in `etc/cli_opts.json`, so minimist parsed them as unrelated `i` and `w` flags. `bin/cli` only reads `flags.indent` and `flags[ 'max-width' ]`, meaning the short forms were silently ignored and the defaults (4 and 80) applied. Ref: 81c7584 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
…eneric/ternary-strided1d/blocked` The `kernel2d` through `kernel10d` signatures in `docs/repl.txt` omitted whitespace after the commas separating the stride and strategy arguments. The sibling `binary-strided1d/blocked` and `unary-strided1d/blocked` packages, and this package's own README, all use spaced parameter lists. Ref: 25aa58a Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
The final element of the `complex128` example output was written as `00.0` instead of `0.0`. Ref: 71a87cf Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
Coverage Report
The above coverage report was generated for the changes in this PR. |
…ernels/generic/ternary-strided1d/blocked`" This reverts commit dc7a4a2334bcd1e2bd0dd35f8b9c9f8b47ef44d0. The compact spacing was not an oversight. REPL help text is capped at 80 characters by `@stdlib/_tools/repl-txt/rules/line-length`, and the ternary signature does not fit with whitespace after every comma: `kernel2d` through `kernel9d` come to 83 characters and `kernel10d` to 84. Dropping the whitespace between the stride and strategy arguments is how the signature was made to fit. The binary and unary siblings have one fewer argument in each group and stay within the limit, which is why they can space theirs out. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
| ], | ||
| "version": [ | ||
| "V" | ||
| ], |
There was a problem hiding this comment.
Why was this re-added? The point is that we don't want these aliases, as they are not commonly used for these purposes and we should avoid confusing users accustomed to other meanings for i and w.
There was a problem hiding this comment.
Understood — reverted in ecf705995; etc/cli_opts.json is back to its state on develop.
What prompted it: docs/usage.txt advertised -i and -w, so minimist parsed them as flags.i/flags.w and bin/cli (reading flags.indent/flags['max-width']) ignored them silently. I fixed the wrong side. ecf705995 drops the two short forms from the usage text instead, rendering them as long-only the way _tools/github/get and net/disposable-http-server do.
Generated by Claude Code
…` usage text `docs/usage.txt` advertised `-i` for `--indent` and `-w` for `--max-width`, but neither alias is registered in `etc/cli_opts.json`, so both were parsed by minimist as `flags.i`/`flags.w` and silently ignored by `bin/cli`. Per review, the aliases are intentionally absent: `i` and `w` carry other conventional meanings and are not wanted here. Remove them from the usage text instead, matching how long-only options are rendered in sibling CLIs such as `_tools/github/get` and `net/disposable-http-server`. This supersedes the alias registration in ea85e50, which is reverted by this commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
`.editorconfig` sets `indent_size = 2` for `usage.txt`, so leading indentation must be a multiple of two. Removing the short forms in ecf7059 left the long-only options at a nine-space indent, which tripped `lint-editorconfig-files`. Shift the option column from 9 to 8 so short-flag rows keep a two-space indent and long-only rows get eight, matching `_tools/github/get`. Description column is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
develop on 2026-09-26
Follow-up fixes for commits merged to
developbetween 2026-09-26 02:09 UTC and 2026-09-26 10:55 UTC (947861b67..05ed6e856, 45 first-parent commits, 279 files).Description
This pull request:
_tools/repl-txt/wrap-text81c7584d9,docs/usage.txtadvertised-ifor--indentand-wfor--max-width, but neither alias is registered inetc/cli_opts.json, so minimist parsed them asflags.i/flags.wwhilebin/clireadsflags.indent/flags['max-width']— both short forms silently no-op'd and the defaults (4, 80) applied. The aliases are intentionally absent (iandwcarry other conventional meanings), soecf705995removes the short forms from the usage text rather than registering them, rendering both as long-only options the way_tools/github/getandnet/disposable-http-serverdo.blas/ext/fill-range71a87cf23:blas/ext/fill-rangecomplex128@exampleinlib/node_modules/@stdlib/blas/ext/fill-range/docs/types/index.d.ts(line 241) shows<Complex128>[ 00.0, 0.0 ]; drop the stray leading zero to0.0.Two intermediate commits net out to nothing and can be skipped when reading the diff:
ea85e5080registered the-i/-waliases inetc/cli_opts.json. That was the wrong side of the inconsistency; reverted inecf705995per review.dc7a4a233added whitespace after the commas in thekernel2d–kernel10dsignatures inndarray/base/kernels/generic/ternary-strided1d/blocked/docs/repl.txt; reverted in164116892. REPL help is capped at 80 characters by@stdlib/_tools/repl-txt/rules/line-length, and the ternary signature runs to 83–84 characters when fully spaced. The compact spacing in25aa58ae7is how the signature was made to fit. The binary and unary siblings have one fewer argument per group and stay under the cap, which is why theirs are spaced.Net diff is 2 files, 3 lines.
Related Issues
No.
Questions
No.
Other
Validation
Checked across the window:
fast/acoshf↔fast/acosh,exp10f↔exp10,cfill/zfill↔gfill,gfill-by↔gfill,fill-range↔copy-within,last-index-of-truthy↔last-index-of-falsy,ternary-strided1d/blocked↔binary-strided1d/blocked,fftpack/ndarray/{float32,float64}/rfftf↔fftpack/ndarray/generic/rfftf,repl-txt/wrap-text↔repl-txt/wrap-desc), againstdocs/style-guides.lib/main.jsvs. Csrc/main.cagreement for the three new float32 math kernels (polynomial coefficients, special-case ordering, NaN/±Inf/domain thresholds); stride/offset/block-size arithmetic in all nineternary-strided1d/blockeddimensionality kernels; dtype→kernel dispatch tables and argument-arity overloads in the newblas/extpackages;examples/index.jsexecuted for every new package.stats/**migrations toisAlmostSameValuewere re-derived empirically against their Julia fixtures; every migrated ULP argument reproduces the measured distance exactly.Deliberately excluded (recorded but not acted on):
docs/types/index.d.tsgaps —rfftfis registered infft/base/fftpack/ndarray/{float32,float64}/lib/index.jsandcfill/zfill/gfillByinblas/ext/base/ndarray/lib/index.js, but none are declared in the corresponding namespace.d.ts.stdlib-botbackfills these automatically —116141557did exactly that forndarray/genericwithin this same window — so hand-editing them here would only conflict with the next bot run.rfftiplaceholder docstring (TODO) infft/base/fftpack/ndarray/float32/docs/types/index.d.ts, same bot-maintained file.// returns <ndarray>[ 2 ]for a zero-dimensional output in theblas/ext/last-index-of-truthyassignexamples — resolving this requires a judgment call on ndarray print formatting."integer"key inwrap-text'setc/cli_opts.json(not a minimist option, no effect) — dead config, out of scope for a targeted fix.Anything requiring interpretation, subjective preference, or changes outside the window's diff to validate was dropped rather than guessed at.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written entirely by Claude Code as part of an automated daily review of commits merged to
develop. Candidate issues were produced by independent reviewer agents, then re-verified by re-reading the diff and the referenced files before any edit was made; findings that could not be reproduced that way were dropped. Two that survived that filter were still wrong and have been reverted, as described above.🤖 Generated with Claude Code
https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J