Skip to content

chore: clean-up - #15565

Merged
kgryte merged 6 commits into
developfrom
philipp/fix-commit-review-2026-09-26
Sep 26, 2026
Merged

kgryte merged 6 commits into
developfrom
philipp/fix-commit-review-2026-09-26

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Follow-up fixes for commits merged to develop between 2026-09-26 02:09 UTC and 2026-09-26 10:55 UTC (947861b67..05ed6e856, 45 first-parent commits, 279 files).

Description

What is the purpose of this pull request?

This pull request:

_tools/repl-txt/wrap-text

  • In 81c7584d9, docs/usage.txt advertised -i for --indent and -w for --max-width, but neither alias is registered in etc/cli_opts.json, so minimist parsed them as flags.i/flags.w while bin/cli reads flags.indent/flags['max-width'] — both short forms silently no-op'd and the defaults (4, 80) applied. The aliases are intentionally absent (i and w carry other conventional meanings), so ecf705995 removes the short forms from the usage text rather than registering them, rendering both as long-only options the way _tools/github/get and net/disposable-http-server do.

blas/ext/fill-range

  • Fix 71a87cf23: blas/ext/fill-range complex128 @example in lib/node_modules/@stdlib/blas/ext/fill-range/docs/types/index.d.ts (line 241) shows <Complex128>[ 00.0, 0.0 ]; drop the stray leading zero to 0.0.

Two intermediate commits net out to nothing and can be skipped when reading the diff:

  • ea85e5080 registered the -i/-w aliases in etc/cli_opts.json. That was the wrong side of the inconsistency; reverted in ecf705995 per review.
  • dc7a4a233 added whitespace after the commas in the kernel2d–kernel10d signatures in ndarray/base/kernels/generic/ternary-strided1d/blocked/docs/repl.txt; reverted in 164116892. REPL help is capped at 80 characters by @stdlib/_tools/repl-txt/rules/line-length, and the ternary signature runs to 83–84 characters when fully spaced. The compact spacing in 25aa58ae7 is how the signature was made to fit. The binary and unary siblings have one fewer argument per group and stay under the cap, which is why theirs are spaced.

Net diff is 2 files, 3 lines.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

Checked across the window:

  • Style guide compliance — every new package was diffed against an established reference sibling of comparable complexity (fast/acoshf ↔ fast/acosh, exp10f ↔ exp10, cfill/zfill ↔ gfill, gfill-by ↔ gfill, fill-range ↔ copy-within, last-index-of-truthy ↔ last-index-of-falsy, ternary-strided1d/blocked ↔ binary-strided1d/blocked, fftpack/ndarray/{float32,float64}/rfftf ↔ fftpack/ndarray/generic/rfftf, repl-txt/wrap-text ↔ repl-txt/wrap-desc), against docs/style-guides.
  • Bug scan — JS lib/main.js vs. C src/main.c agreement for the three new float32 math kernels (polynomial coefficients, special-case ordering, NaN/±Inf/domain thresholds); stride/offset/block-size arithmetic in all nine ternary-strided1d/blocked dimensionality kernels; dtype→kernel dispatch tables and argument-arity overloads in the new blas/ext packages; examples/index.js executed for every new package.
  • ULP test migrations — the seven stats/** migrations to isAlmostSameValue were re-derived empirically against their Julia fixtures; every migrated ULP argument reproduces the measured distance exactly.

Deliberately excluded (recorded but not acted on):

  • Namespace docs/types/index.d.ts gaps — rfftf is registered in fft/base/fftpack/ndarray/{float32,float64}/lib/index.js and cfill/zfill/gfillBy in blas/ext/base/ndarray/lib/index.js, but none are declared in the corresponding namespace .d.ts. stdlib-bot backfills these automatically — 116141557 did exactly that for ndarray/generic within this same window — so hand-editing them here would only conflict with the next bot run.
  • The rffti placeholder docstring (TODO) in fft/base/fftpack/ndarray/float32/docs/types/index.d.ts, same bot-maintained file.
  • // returns <ndarray>[ 2 ] for a zero-dimensional output in the blas/ext/last-index-of-truthy assign examples — resolving this requires a judgment call on ndarray print formatting.
  • The unused "integer" key in wrap-text's etc/cli_opts.json (not a minimist option, no effect) — dead config, out of scope for a targeted fix.

Anything requiring interpretation, subjective preference, or changes outside the window's diff to validate was dropped rather than guessed at.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written entirely by Claude Code as part of an automated daily review of commits merged to develop. Candidate issues were produced by independent reviewer agents, then re-verified by re-reading the diff and the referenced files before any edit was made; findings that could not be reproduced that way were dropped. Two that survived that filter were still wrong and have been reverted, as described above.


🤖 Generated with Claude Code

https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J

The CLI usage text documents `-i` and `-w` as short forms of `--indent`
and `--max-width`, but neither was registered in `etc/cli_opts.json`, so
minimist parsed them as unrelated `i` and `w` flags. `bin/cli` only reads
`flags.indent` and `flags[ 'max-width' ]`, meaning the short forms were
silently ignored and the defaults (4 and 80) applied.

Ref: 81c7584

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
…eneric/ternary-strided1d/blocked`

The `kernel2d` through `kernel10d` signatures in `docs/repl.txt` omitted
whitespace after the commas separating the stride and strategy arguments.
The sibling `binary-strided1d/blocked` and `unary-strided1d/blocked`
packages, and this package's own README, all use spaced parameter lists.

Ref: 25aa58a

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
The final element of the `complex128` example output was written as
`00.0` instead of `0.0`.

Ref: 71a87cf

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
@stdlib-bot

stdlib-bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/fill-range $\\color{green}484/484$
$\\color{green}+0.00\\%$
$\\color{green}55/55$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}484/484$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

…ernels/generic/ternary-strided1d/blocked`"

This reverts commit dc7a4a2334bcd1e2bd0dd35f8b9c9f8b47ef44d0.

The compact spacing was not an oversight. REPL help text is capped at 80
characters by `@stdlib/_tools/repl-txt/rules/line-length`, and the ternary
signature does not fit with whitespace after every comma: `kernel2d`
through `kernel9d` come to 83 characters and `kernel10d` to 84. Dropping
the whitespace between the stride and strategy arguments is how the
signature was made to fit. The binary and unary siblings have one fewer
argument in each group and stay within the limit, which is why they can
space theirs out.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
@kgryte
kgryte marked this pull request as ready for review September 26, 2026 20:27
@kgryte
kgryte requested a review from a team September 26, 2026 20:27
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 26, 2026
],
"version": [
"V"
],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this re-added? The point is that we don't want these aliases, as they are not commonly used for these purposes and we should avoid confusing users accustomed to other meanings for i and w.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood — reverted in ecf705995; etc/cli_opts.json is back to its state on develop.

What prompted it: docs/usage.txt advertised -i and -w, so minimist parsed them as flags.i/flags.w and bin/cli (reading flags.indent/flags['max-width']) ignored them silently. I fixed the wrong side. ecf705995 drops the two short forms from the usage text instead, rendering them as long-only the way _tools/github/get and net/disposable-http-server do.


Generated by Claude Code

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comment.

…` usage text

`docs/usage.txt` advertised `-i` for `--indent` and `-w` for `--max-width`,
but neither alias is registered in `etc/cli_opts.json`, so both were parsed
by minimist as `flags.i`/`flags.w` and silently ignored by `bin/cli`.

Per review, the aliases are intentionally absent: `i` and `w` carry other
conventional meanings and are not wanted here. Remove them from the usage
text instead, matching how long-only options are rendered in sibling CLIs
such as `_tools/github/get` and `net/disposable-http-server`.

This supersedes the alias registration in ea85e50, which is reverted by
this commit.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
`.editorconfig` sets `indent_size = 2` for `usage.txt`, so leading
indentation must be a multiple of two. Removing the short forms in
ecf7059 left the long-only options at a nine-space indent, which
tripped `lint-editorconfig-files`.

Shift the option column from 9 to 8 so short-flag rows keep a two-space
indent and long-only rows get eight, matching `_tools/github/get`.
Description column is unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LeUVqypEsPk1bBjJY3615J
@kgryte kgryte changed the title fix: follow-up fixes for commits merged to develop on 2026-09-26 chore: clean-up Sep 26, 2026
@kgryte
kgryte merged commit cda4adf into develop Sep 26, 2026
11 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-09-26 branch September 26, 2026 20:39
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants