Skip to content

test: migrate stats/incr/mhmean to ULP-based assertions - #15561

Merged
kgryte merged 1 commit into
developfrom
philipp/ulp-stats-incr-mhmean
Sep 26, 2026
Merged

kgryte merged 1 commit into
developfrom
philipp/ulp-stats-incr-mhmean

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates stats/incr/mhmean's test suite from relative-tolerance (EPS * abs(...)) comparisons to ULP-difference assertions using @stdlib/assert/is-almost-same-value.
  • removes the now-unused abs and EPS (@stdlib/constants/float64/eps) requires from test/test.js.
  • tightens each converted assertion to the minimum ULP tolerance that still passes deterministically across repeated runs:
    • the moving harmonic mean fixture loop (6 values): 1 ULP.
    • the "no input value provided" single-value case: 2 ULP.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Ran test/test.js for this package directly and via make test TESTS_FILTER=".*/stats/incr/mhmean/.*" twice at the final ULP values to confirm deterministic results (41/41 passing both times). npx eslint is clean on the modified file. Only test/test.js was changed; no test.native.js exists for this package and no package.json changes were required.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code, run as an unattended scheduled task on the repo maintainer's (Planeshifter's) own account. It selected this package by scanning the repo for the old relative-tolerance idiom, mirrored the conversion pattern from prior merged PRs for this issue (e.g. commits migrating stats/incr/mmda, stats/incr/nanpcorrdist, and stats/base/dists/uniform/variance), and determined the minimum ULP bounds empirically by running the test suite.


@stdlib-js/reviewers


🤖 Generated with Claude Code

https://claude.ai/code/session_012mhq6GePBcsMEYEDQh3R1Y


Generated by Claude Code

Resolves a part of #11352

Replaces relative-tolerance comparisons (`EPS * abs(...)`) in the
package's test suite with `isAlmostSameValue` ULP-difference
assertions, tightened to the minimum ULP required for each case.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012mhq6GePBcsMEYEDQh3R1Y

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Sep 26, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/mhmean $\\color{green}165/165$
$\\color{green}+100.00\\%$
$\\color{green}9/9$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}165/165$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Sep 26, 2026
@kgryte
kgryte marked this pull request as ready for review September 26, 2026 09:41
@kgryte
kgryte requested a review from a team September 26, 2026 09:41
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 26, 2026
@kgryte
kgryte merged commit 33b0476 into develop Sep 26, 2026
82 checks passed
@kgryte
kgryte deleted the philipp/ulp-stats-incr-mhmean branch September 26, 2026 09:41
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants