Repository navigation
test: migrate stats/incr/mmda to ULP-based assertions - #15553
Merged
Merged
Conversation
Migrate the tests for `stats/incr/mmda` from a computed relative-tolerance comparison to a ULP-difference assertion using `@stdlib/assert/is-almost-same-value`. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015zhnGzDyHjTMnyzw3r22H6 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
kgryte
marked this pull request as ready for review
September 26, 2026 02:30
stdlib-bot
added
Good First PR
Contributor
Coverage ReportNo coverage information available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/mmdafrom a computed relative-tolerance comparison (delta = abs( expected[i] - actual )/tol = 1.0 * EPS * abs( expected[i] ), asserted viat.strictEqual( delta <= tol, ... )) to a ULP-difference assertion using@stdlib/assert/is-almost-same-value.test/test.js. The package has notest/test.native.js, and the remaining assertions in the file are exact comparisons againstnull,NaN, and exactly representable values, which are correct as-is and are left unchanged.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with thedeltaandtolvariable declarations.if ( actual === expected[i] ) { ... } else { ... }branch in the moving mean directional accuracy test into a single ULP assertion, matching the migrated idiom.Only a test file is changed; no implementation, fixture, or documentation changes are included.
ULP bounds
1.0 * EPS * abs( expected[i] )00is the minimum integer boundNsuch thatisAlmostSameValue( actual, expected[i], N )holds at the assertion site, and it is minimal by construction, sinceNcannot be lowered further.The bound was measured independently of the test harness by computing
ulpDifference( actual, expected[i] )directly at every element of the fixture, starting from a high bound (64, which passes) and tightening. The per-element ULP differences are0, 0, 0, 0, 0, 0, 0, 0: the accumulator reproduces each hand-computed expected value (1,1/2,2/3,1/3,0) exactly. This is expected for this accumulator, since each returned value is a ratio of small integer counts over a fixed window, so no rounding error accumulates. Note that atN = 0,isAlmostSameValuereduces to the SameValue algorithm, which still distinguishes+0from-0; the single zero-valued expectation (0.0/3.0) is+0on both sides, so the assertion holds.make test TESTS_FILTER=".*/stats/incr/mmda/.*"was run three times at the final bound with identical results: 108/108 passing on every run, no failures, ruling out FMA/architecture-dependent flakiness on this platform.make lint-javascript-tests TESTS_FILTER=".*/stats/incr/mmda/.*"is clean.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
As with the sibling package
stats/incr/nanmmda(#15131), the pre-existing test already had an exact-equality fast path (if ( actual === expected[i] )) with the relative-tolerance comparison only as a fallback, and the fallback turns out never to be taken. The migration therefore collapses toN = 0, matching the idiom used elsewhere in the migration. Flagging in case a reviewer would prefer a plaint.strictEqual( actual, expected[i], ... )at this site instead; no such change was made, since it would go beyond migrating the assertion.Other
The resulting diff mirrors the already-merged migration for the sibling package
stats/incr/nanmmda(#15131), which has the same accumulator test structure and the same0ULP bound.Two environment notes, neither of which affected verification:
make install-node-modulesinitially failed withETARGETfores-object-atoms@^1.1.2. The cause was a stale npm metadata cache in this sandbox: the live registry publishes1.1.2, but the cached packument topped out at1.1.1. Afternpm cache clean --force,make install-node-modulesandmake initboth succeeded normally, with no change to the repository.lint-editorconfig-filespre-commit step could not download theeditorconfig-checkerbinary in this sandbox and was skipped viaSKIP_LINT_EDITORCONFIG; the changed lines were checked manually for LF line endings, tab indentation, no trailing whitespace, and a final newline. All other pre-commit lint steps ran normally, includinglint_javascript_tests.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running as an unattended scheduled task. It selected the package, studied previously migrated packages in the same family to match the established idiom, performed the migration, and determined the minimum passing ULP bound empirically at the assertion site.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_015zhnGzDyHjTMnyzw3r22H6
Generated by Claude Code