Skip to content

feat: add blas/ext/fill-range - #15544

Merged
kgryte merged 11 commits into
stdlib-js:developfrom
headlessNode:blas/fill
Sep 26, 2026
Merged

kgryte merged 11 commits into
stdlib-js:developfrom
headlessNode:blas/fill

Conversation

@headlessNode

Copy link
Copy Markdown
Member

Resolves stdlib-js/metr-issue-tracker#1369.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/fill

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.


@stdlib-js/reviewers

@headlessNode
headlessNode requested a review from a team September 25, 2026 18:54
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Sep 25, 2026
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. labels Sep 25, 2026
@stdlib-bot

stdlib-bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/fill-range $\\color{green}484/484$
$\\color{green}+0.00\\%$
$\\color{green}55/55$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}484/484$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte

kgryte commented Sep 26, 2026

Copy link
Copy Markdown
Member

I am wondering if we should rename this package to blas/ext/fill-from in order to distinguish it from ndarray/fill. The reason being that both are top-level ndarray APIs which "fill" an ndarray. And in the global namespace (including in the REPL), we'll need separate aliases for the two APIs.

Thoughts?

@kgryte kgryte added the Needs Discussion Needs further discussion. label Sep 26, 2026
@headlessNode

Copy link
Copy Markdown
Member Author

@kgryte I'm not sure on the naming here. fill-from give me the vibes that the start is not optional. Also, another question with that is why not fill-to.

fill-range combines both, but am not sure on that either.

@kgryte

kgryte commented Sep 26, 2026

Copy link
Copy Markdown
Member

@headlessNode fill-range seems good enough. I don't have a better name.

https://chatgpt.com/share/6ab76cd3-9f64-83e8-9d50-107c687debb3

@headlessNode

Copy link
Copy Markdown
Member Author

@kgryte Name changed plus other updates.

@headlessNode headlessNode removed the Needs Discussion Needs further discussion. label Sep 26, 2026
@kgryte kgryte changed the title feat: add blas/ext/fill feat: add blas/ext/fill-range Sep 26, 2026
@kgryte kgryte added review: 5 and removed Needs Review A pull request which needs code review. labels Sep 26, 2026
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/lib/broadcast_index.js
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/lib/broadcast_index.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/README.md Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/README.md Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Sep 26, 2026
@kgryte kgryte removed the review: 5 label Sep 26, 2026
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/docs/types/index.d.ts Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/docs/types/index.d.ts Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/docs/types/index.d.ts Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/docs/types/index.d.ts Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/docs/types/index.d.ts Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/docs/types/index.d.ts Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Sep 26, 2026
Comment thread lib/node_modules/@stdlib/blas/ext/fill-range/docs/types/index.d.ts Outdated
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
kgryte merged commit 71a87cf into stdlib-js:develop Sep 26, 2026
13 checks passed
@headlessNode
headlessNode deleted the blas/fill branch September 26, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/fill

3 participants