Skip to content

test: increase tolerance to account for compiler optimizations #15534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 3 commits into from
Sep 26, 2026
Merged

test: increase tolerance to account for compiler optimizations #15534

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66c410b
fix: restore FMA tolerance in `stats/base/dists/triangular/skewness` …
claude Sep 25, 2026
fbf568b
docs: fix precision in `fft/base/fftpack/float32/rfftf` JSDoc comment
claude Sep 25, 2026
55e5079
Discard changes to lib/node_modules/@stdlib/fft/base/fftpack/float32/…
kgryte Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/node_modules/@stdlib/stats/base/dists/triangular/skewness/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ tape( 'the function returns the skewness of a triangular distribution', opts, fu
c = data.c;
for ( i = 0; i < expected.length; i++ ) {
y = skewness( a[ i ], b[ i ], c[ i ] );
t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );

// Note: large tolerance needed due to FMA (fused multiply-add) operations. With CFLAGS="-ffp-contract=off", the tolerance can be 0 ULPs.
t.strictEqual( isAlmostSameValue( y, expected[ i ], 96000 ), true, 'returns expected value' );
}
t.end();
});
Loading