Skip to content

test: migrate stats/base/dists/bradford/variance to ULP-based assertions - #15528

Merged
kgryte merged 1 commit into
developfrom
philipp/ulp-bradford-variance
Sep 25, 2026
Merged

kgryte merged 1 commit into
developfrom
philipp/ulp-bradford-variance

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates stats/base/dists/bradford/variance test cases from relative tolerance testing to ULP (units in the last place) difference testing, per the guidance in [RFC]: Migrate math/base/special packages from relative tolerance testing to ULP difference testing (tracking issue) #11352.
  • replaces the delta/tol relative-tolerance idiom in test/test.js and test/test.native.js with @stdlib/assert/is-almost-same-value, tightened to the minimum ULP bound that still passes across the full fixture set:
    • small c fixtures: 856 ULPs (both test.js and test.native.js)
    • large c fixtures: 20 ULPs (both test.js and test.native.js)
  • these bounds were determined by computing the exact ULP distance between actual and expected values for every fixture (via @stdlib/number/float64/base/ulp-difference) and confirmed to be the minimum integer bound that passes (one ULP lower fails). The test suite was run twice at the final bound to confirm determinism.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written by Claude Code, which searched the codebase for a package still using the relative-tolerance testing idiom, studied prior-art conversions (e.g. #15294 for the sibling stats/base/dists/bradford/entropy package) and issue #11352, converted test/test.js and test/test.native.js to use isAlmostSameValue, and empirically determined the minimum ULP bounds by computing exact ULP differences against the fixtures (building the package's native add-on locally to verify test.native.js as well).


@stdlib-js/reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_011jtHegiyumowZHcu4H1ofX


Generated by Claude Code

…tions

Replace relative tolerance comparisons with `isAlmostSameValue` ULP-based
assertions, tightened to the minimum ULP bound that still passes across
the full fixture set.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011jtHegiyumowZHcu4H1ofX

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Sep 25, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/bradford/variance $\\color{green}183/183$
$\\color{green}+100.00\\%$
$\\color{green}8/8$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}183/183$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Sep 25, 2026
@kgryte
kgryte marked this pull request as ready for review September 25, 2026 10:53
@kgryte
kgryte requested a review from a team September 25, 2026 10:53
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 25, 2026
@kgryte
kgryte merged commit 8671d2a into develop Sep 25, 2026
82 checks passed
@kgryte
kgryte deleted the philipp/ulp-bradford-variance branch September 25, 2026 10:54
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants