Skip to content

test: migrate stats/incr/mvariance to ULP-based assertions - #15526

Merged
kgryte merged 1 commit into
developfrom
kgryte/ulp-stats-incr-mvariance
Sep 25, 2026
Merged

kgryte merged 1 commit into
developfrom
kgryte/ulp-stats-incr-mvariance

Conversation

@kgryte

@kgryte kgryte commented Sep 25, 2026

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

Only test/test.js is modified; the package has no test/test.native.js. No implementation, fixture, documentation, or benchmark changes are included. The existing exact-comparison assertions (t.deepEqual over the incremental result arrays, the NaN window checks, and the null/0 sentinel checks) are left untouched, since those values are exactly representable.

ULP bounds

The package has two relative tolerance sites, one assertion each:

Test Previous tolerance ULP Measured minimum
if not provided an input value, the accumulator function returns the current unbiased sample variance EPS 0 0
if not provided an input value, the accumulator function returns the current unbiased sample variance (known mean) EPS 0 0

Starting from 64 and tightening, 0 is the smallest bound which still passes. Both accumulated results are bit-for-bit equal to their expected values, so the ULP difference is zero in each case:

Expected Actual ULP difference
19.0 19 0
12.666666666666666 12.666666666666666 0

The previous delta < tol formulation was strictly weaker than necessary here: the implementation already returns the exactly expected double, so the relative tolerance was never being consumed.

The suite was run twice at the final bound, passing 396/396 both times, with no variation between runs.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Verified locally with make test-javascript TESTS_FILTER=".*/stats/incr/mvariance/.*" (396/396 passing, run twice) and make lint-javascript-tests TESTS_FILTER=".*/stats/incr/mvariance/.*" (clean).

The idiom mirrors the already-migrated sibling stats/incr/mvmr, which has an identical require set (tape, randu, isAlmostSameValue, isnan, zeros) and the same require ordering.

One note on local verification: make lint-editorconfig-files could not run in this environment, because it downloads the editorconfig-checker binary from a GitHub repository which was outside the network allowlist available here. The same target fails identically on unmodified files already on develop, so this is environmental and not specific to these changes. Editorconfig conformance for the modified file was instead confirmed directly (LF line endings, tab indentation, no trailing whitespace, final newline present, ASCII only).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code, which selected the package, studied already-migrated packages to match the established idiom, performed the migration, and searched for the minimum passing ULP bound by measurement.


@stdlib-js/reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_011JBBkFSsB79CXspCquYadq


Generated by Claude Code

Ref: #11352

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011JBBkFSsB79CXspCquYadq

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Sep 25, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/mvariance $\\color{green}363/363$
$\\color{green}+100.00\\%$
$\\color{green}53/53$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}363/363$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Sep 25, 2026
@kgryte
kgryte marked this pull request as ready for review September 25, 2026 06:49
@kgryte
kgryte requested a review from a team September 25, 2026 06:49
@kgryte
kgryte merged commit e17a0b7 into develop Sep 25, 2026
66 checks passed
@kgryte
kgryte deleted the kgryte/ulp-stats-incr-mvariance branch September 25, 2026 06:49
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants