Repository navigation
test: migrate stats/incr/mvariance to ULP-based assertions - #15526
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011JBBkFSsB79CXspCquYadq --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
September 25, 2026 06:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
@stdlib/stats/incr/mvariancefrom relative tolerance (EPS-scaled) assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with the associateddelta/tolbookkeeping.Only
test/test.jsis modified; the package has notest/test.native.js. No implementation, fixture, documentation, or benchmark changes are included. The existing exact-comparison assertions (t.deepEqualover the incremental result arrays, theNaNwindow checks, and thenull/0sentinel checks) are left untouched, since those values are exactly representable.ULP bounds
The package has two relative tolerance sites, one assertion each:
if not provided an input value, the accumulator function returns the current unbiased sample varianceEPS00if not provided an input value, the accumulator function returns the current unbiased sample variance (known mean)EPS00Starting from
64and tightening,0is the smallest bound which still passes. Both accumulated results are bit-for-bit equal to their expected values, so the ULP difference is zero in each case:19.019012.66666666666666612.6666666666666660The previous
delta < tolformulation was strictly weaker than necessary here: the implementation already returns the exactly expected double, so the relative tolerance was never being consumed.The suite was run twice at the final bound, passing
396/396both times, with no variation between runs.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verified locally with
make test-javascript TESTS_FILTER=".*/stats/incr/mvariance/.*"(396/396passing, run twice) andmake lint-javascript-tests TESTS_FILTER=".*/stats/incr/mvariance/.*"(clean).The idiom mirrors the already-migrated sibling
stats/incr/mvmr, which has an identical require set (tape,randu,isAlmostSameValue,isnan,zeros) and the same require ordering.One note on local verification:
make lint-editorconfig-filescould not run in this environment, because it downloads theeditorconfig-checkerbinary from a GitHub repository which was outside the network allowlist available here. The same target fails identically on unmodified files already ondevelop, so this is environmental and not specific to these changes. Editorconfig conformance for the modified file was instead confirmed directly (LF line endings, tab indentation, no trailing whitespace, final newline present, ASCII only).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which selected the package, studied already-migrated packages to match the established idiom, performed the migration, and searched for the minimum passing ULP bound by measurement.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_011JBBkFSsB79CXspCquYadq
Generated by Claude Code