Repository navigation
chore: clean-up - #15517
Merged
kgryte merged 3 commits intoSep 25, 2026
Merged
chore: clean-up#15517
Conversation
…sts/bradford/mean` The `## C APIs` heading and its nested intro, usage, notes, and examples blocks were not enclosed in a `<section class="c">` element, leaving the C documentation at the same level as the JavaScript documentation. Eight of the ten `bradford` packages (80%) enclose the block, as do 1612 of the 1614 packages repo-wide that ship a C implementation alongside a `C APIs` README heading. Because the C intro, usage, notes, and examples blocks sat at the root level, they duplicated the class names of their JavaScript counterparts. Reparenting them under the `c` section removes four latent `duplicate-section` warnings and activates the `remark-lint-expected-html-sections` `c` branch, whose required nested `usage` and `examples` blocks are already present. Also normalize the preceding HTML comment from `C API documentation.` to `C interface documentation.`, matching the same eight siblings, the canonical snippet in `tools/snippets/c.md`, and 1929 of 1930 occurrences repo-wide. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kb86RxT3YPqc4KzHz4vDfi
…sts/bradford/skewness` The `## C APIs` heading and its nested intro, usage, notes, and examples blocks were not enclosed in a `<section class="c">` element, leaving the C documentation at the same level as the JavaScript documentation. Eight of the ten `bradford` packages (80%) enclose the block, as do 1612 of the 1614 packages repo-wide that ship a C implementation alongside a `C APIs` README heading. Because the C intro, usage, notes, and examples blocks sat at the root level, they duplicated the class names of their JavaScript counterparts. Reparenting them under the `c` section removes four latent `duplicate-section` warnings and activates the `remark-lint-expected-html-sections` `c` branch, whose required nested `usage` and `examples` blocks are already present. Also add the missing `C interface documentation.` HTML comment ahead of the block, matching the same eight siblings, the canonical snippet in `tools/snippets/c.md`, and 1929 of 1930 occurrences repo-wide. The existing horizontal rule and the trailing `references` section are left untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kb86RxT3YPqc4KzHz4vDfi
Contributor
Coverage ReportNo coverage information available. |
c section in two stats/base/dists/bradford READMEsc section in stats/base/dists/bradford
kgryte
marked this pull request as ready for review
September 25, 2026 02:28
kgryte
reviewed
Sep 25, 2026
kgryte
reviewed
Sep 25, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Sep 25, 2026
c section in stats/base/dists/bradford
kgryte
deleted the
philipp/drift-stats-base-dists-bradford-2026-09-25
branch
September 25, 2026 02:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
## C APIsblock ofstats/base/dists/bradford/meanandstats/base/dists/bradford/skewnessin a<section class="c">element and normalizes the HTML comment that precedes it, making the two READMEs structurally identical to their siblings. No rendered prose changes.Namespace summary
stats/base/dists/bradfordcdf,entropy,mean,median,mode,pdf,quantile,skewness,stdev,variance); none autogeneratedpackage.jsonkey set,scriptskey set,keywords,manifest.jsonkey set, README heading sequence, README section structure,test/benchmark/examplesfile naming, public signature, validation prologue, JSDoc shape* * *rule preceding the C block (4/10, subsequently added tomeanon review; see below) and theunivariatekeyword (4/10, excluded)stats/base/dists/bradford/meanAdds the
<section class="c">wrapper around## C APIsinmean/README.md, enclosing the nestedintro,usage,notes, andexamplesblocks and bringingbradford/meanin line with 8 of its 10 sibling packages (80%) and 1612 of 1614 packages repo-wide that pair a C implementation with a## C APIsheading. Reparenting these blocks clears four latentduplicate-sectionwarnings caused by their class names colliding with the JavaScript counterparts at root level, and satisfies theremark-lint-expected-html-sectionscbranch's requirement for nestedusageandexamplesblocks, both already present. Also normalizes the preceding comment from<!-- C API documentation. -->to<!-- C interface documentation. -->, matchingtools/snippets/c.mdand 1929 of 1930 occurrences repo-wide.Two further corrections were applied on review: the
* * *rule ahead of thecsection, and removal of a stray blank line before the closing fence of the JavaScript examples block. The blank line predates this PR and mademeanthe only member of the namespace whose examples block ends on an empty line.stats/base/dists/bradford/skewnessThe
## C APIssection inskewness/README.mdlacked the<section class="c">wrapper and its<!-- C interface documentation. -->marker, leaving theintro,usage,notes, andexamplesblocks at root level where they collided with their JavaScript counterparts' class names. This leftbradford/skewness, alongsidebradford/mean, as the only two exceptions among the 1614 packages repo-wide that pair a C implementation with a## C APIsheading. Wrapping the blocks in<section class="c">/<!-- /.c -->, placed before the untouched<section class="references">, brings the package in line with its 8bradfordsiblings (80%) and clears four latentduplicate-sectionwarnings.Related Issues
No.
Questions
No.
Other
Validation
Checked:
package.json/scripts/stdlib/manifest.jsonkey sets, README heading sequence and<section>structure, andtest/benchmark/examplesfile naming.require()dependency set.remark-lint-expected-html-sectionsandremark-lint-html-section-structureas configured byetc/remark/plugins/pkg_readmes.js. Thecclass is optional at root but requires nestedusageandexampleswhen present; both READMEs already carry them, so the newly activated branch passes. Section balance and</section>→<!-- /.class -->pairing were verified to matchmedian/README.mdandvariance/README.mdexactly.</section>relative to<section class="references">, against the 777 packages repo-wide that carry both.Deliberately excluded:
stdevhas an empty validation prologue because it issqrt( variance( c ) )in both JS and C andvariancealready guardsisnan( c ) || c <= 0.0; adding a guard would be dead code.modehas notest/fixtures/python/runner.pybecausemode( c )is the constant0.0and there are no reference values to generate.skewnesslacks adocs/img/equation SVG, which is produced by theremark-svg-equations-to-filetooling and referenced only from a commented-out, SHA-pinned fallback<img>; the package already renders its equation through the current fencedmathblock.repl.txt,docs/types/*.d.ts, and the auto-populated## See Alsoblocks were out of scope throughout.* * *rule before the C block appears in only 4/10 members, below the 75% threshold, so it was initially left as found. It was added tomeanon review: repo-wide the rule is present in 1926/1948 packages carrying acsection and is part oftools/snippets/c.md, so the namespace sample was the misleading signal.skewnessalready carried it. Theunivariatekeyword (4/10) remains excluded.skewedkeyword is present in 8/10 members and absent fromquantileandskewness. It was dropped:quantileis already touched by open PR refactor: correctUnaryprobability parameter inbase/dists/bradford/quantile#12496, and everyskewnesspackage across the other distribution namespaces usesskewness/shape/asymmetryin its place.No test or example reads either README, and neither package's
docs/types/test.tsis affected.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, as part of an automated cross-package drift audit. The outliers were found by extracting structural and semantic features from all 10 members of the namespace and taking a per-feature majority vote at a 75% threshold; each candidate correction was then reviewed by separate agents for semantic justification, test/tooling dependencies, and structural applicability before being applied. The resulting diff is documentation markup only.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Kb86RxT3YPqc4KzHz4vDfi