Skip to content

chore: fix JavaScript lint errors - #15514

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
Shubhangi05-code-jpg:fix-lint-15414
Sep 25, 2026
Merged

kgryte merged 2 commits into
stdlib-js:developfrom
Shubhangi05-code-jpg:fix-lint-15414

Conversation

@Shubhangi05-code-jpg

@Shubhangi05-code-jpg Shubhangi05-code-jpg commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Resolves #15414.

Description

What is the purpose of this pull request?

This pull request fixes the Javascript lint error reported by ESLint in lib/node_modules/@stdlib/_tools/makie/plugins/makie-view-complexity/lib/main.js..

Replaces the disallowed new Array ( ) usage with array literal.

Related Issues

Does this pull request have any related issues?

No

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • [ *] Research and understanding

Disclosure

I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.


@stdlib-js/reviewers

@Shubhangi05-code-jpg
Shubhangi05-code-jpg requested a review from a team September 24, 2026 20:35
@stdlib-bot stdlib-bot added the Tools Issue or pull request related to project tooling. label Sep 24, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Sep 24, 2026
Comment thread lib/node_modules/@stdlib/_tools/makie/plugins/makie-view-complexity/lib/main.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 3 and removed Needs Review A pull request which needs code review. labels Sep 25, 2026
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Sep 25, 2026
@kgryte kgryte changed the title chore: Javascript lint errors(issue #15414) chore: fix Javascript lint errors Sep 25, 2026
@kgryte kgryte changed the title chore: fix Javascript lint errors chore: fix JavaScript lint errors Sep 25, 2026
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Sep 25, 2026
@kgryte
kgryte merged commit 63f3434 into stdlib-js:develop Sep 25, 2026
81 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. review: 3 Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants