Skip to content

test: migrate stats/base/dists/triangular/skewness to ULP-based assertions - #15505

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
Devansh-18155:devansh/ulp-triangular-skewness
Sep 24, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
Devansh-18155:devansh/ulp-triangular-skewness

Conversation

@Devansh-18155

Copy link
Copy Markdown
Contributor

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates unit tests for @stdlib/stats/base/dists/triangular/skewness from relative tolerance checks (delta <= tol) to ULP-based assertions using @stdlib/assert/is-almost-same-value.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@Devansh-18155
Devansh-18155 requested a review from a team September 24, 2026 16:33
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 24, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/triangular/skewness $\\color{green}210/210$
$\\color{green}+100.00\\%$
$\\color{green}11/11$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}210/210$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title test: migrate stdlib/stats/base/dists/triangular/skewness to ULP-based assertions test: migrate stats/base/dists/triangular/skewness to ULP-based assertions Sep 24, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 and removed Needs Review A pull request which needs code review. labels Sep 24, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
kgryte merged commit a592a8d into stdlib-js:develop Sep 24, 2026
117 checks passed
@Planeshifter Planeshifter mentioned this pull request Sep 25, 2026
5 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5 Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants