Skip to content

docs: add Git notes correcting recent commit messages - #15501

Closed
Planeshifter wants to merge 2 commits into
developfrom
philipp/git-notes-20260924
Closed

Planeshifter wants to merge 2 commits into
developfrom
philipp/git-notes-20260924

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds a Git note under docs/git-notes/ proposing a corrected commit message for one commit merged to develop in the last 24 hours whose subject line contains an incorrect package scope.

Flagged commits

  • 68b4b338: incorrect scope in subject — commit subject reads test: migrate \base/dists/triangular/stdev` to ULP-based assertions, but no package exists at base/dists/triangular/stdev. The actual package is stats/base/dists/triangular/stdev(confirmed to exist in the tree), and the merged PR's own title (#15460) correctly used the fullstats/base/dists/triangular/stdevpath. Every sibling "ULP-based assertions" migration commit in the same 24-hour window consistently includes thestats/prefix (e.g.stats/base/dists/poisson/mean, stats/incr/mme, stats/ttest2), so this commit's dropped prefix is an isolated, mechanical typo rather than a naming convention. The note restores the correct scope; all other trailers (PR-URL, Reviewed-by, Ref`) are preserved as-is.

Audit scope

21 non-merge commits from the last 24 hours on develop were reviewed (git show --no-patch --pretty=fuller on each):

  • All 19 PR-URL references were verified via the GitHub API to exist, be merged into stdlib-js/stdlib, and match the referenced commit's subject/content. No wrong or non-existent PR references were found.
  • Two commits (e131d88e, 612a0c16) have no PR-URL trailer at all — one carries the standard pre-commit static-analysis-report body instead of trailers, and the other (an stdlib-bot commit committed directly by a maintainer) has no trailers. Both match the established pattern for direct, non-PR pushes seen in prior audits of this repository and were not flagged.
  • No spelling/grammar typos found in any other subject or body.
  • No malformed trailers (duplicated Co-authored-by, broken emails) found. Commits missing Signed-off-by follow the repository's established pattern (no Co-authored-by/AI-assistance context requiring one) and were not flagged.
  • All other subjects follow the stdlib Conventional Commits style (type(scope): description, lowercase imperative subject).

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written primarily by Claude Code, running as an unattended scheduled audit routine. It fetched and inspected each of the 21 non-merge commits from the last 24 hours, verified all PR/issue references against the GitHub API, cross-checked referenced package scopes against the actual repository tree, and found one commit with a scope typo.


@stdlib-js/reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_014CiAyuGyUFw2Agz5ehxWND


Generated by Claude Code

claude and others added 2 commits September 24, 2026 14:10
@kgryte kgryte added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label Sep 24, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants