Repository navigation
docs: add Git notes correcting recent commit messages - #15501
Closed
Planeshifter wants to merge 2 commits into
Closed
Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Contributor
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves none.
Description
This pull request:
docs/git-notes/proposing a corrected commit message for one commit merged todevelopin the last 24 hours whose subject line contains an incorrect package scope.Flagged commits
68b4b338: incorrect scope in subject — commit subject readstest: migrate \base/dists/triangular/stdev` to ULP-based assertions, but no package exists atbase/dists/triangular/stdev. The actual package isstats/base/dists/triangular/stdev(confirmed to exist in the tree), and the merged PR's own title (#15460) correctly used the fullstats/base/dists/triangular/stdevpath. Every sibling "ULP-based assertions" migration commit in the same 24-hour window consistently includes thestats/prefix (e.g.stats/base/dists/poisson/mean,stats/incr/mme,stats/ttest2), so this commit's dropped prefix is an isolated, mechanical typo rather than a naming convention. The note restores the correct scope; all other trailers (PR-URL,Reviewed-by,Ref`) are preserved as-is.Audit scope
21 non-merge commits from the last 24 hours on
developwere reviewed (git show --no-patch --pretty=fulleron each):PR-URLreferences were verified via the GitHub API to exist, be merged intostdlib-js/stdlib, and match the referenced commit's subject/content. No wrong or non-existent PR references were found.e131d88e,612a0c16) have noPR-URLtrailer at all — one carries the standard pre-commit static-analysis-report body instead of trailers, and the other (anstdlib-botcommit committed directly by a maintainer) has no trailers. Both match the established pattern for direct, non-PR pushes seen in prior audits of this repository and were not flagged.Co-authored-by, broken emails) found. Commits missingSigned-off-byfollow the repository's established pattern (noCo-authored-by/AI-assistance context requiring one) and were not flagged.type(scope): description, lowercase imperative subject).Related Issues
No.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running as an unattended scheduled audit routine. It fetched and inspected each of the 21 non-merge commits from the last 24 hours, verified all PR/issue references against the GitHub API, cross-checked referenced package scopes against the actual repository tree, and found one commit with a scope typo.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_014CiAyuGyUFw2Agz5ehxWND
Generated by Claude Code