Repository navigation
test: migrate stats/iter/mmeanabs2 to ULP-based assertions - #15440
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01REEty7dbxKciFfLkvMt3K6 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Resolves a part of #11352.
Description
This pull request:
@stdlib/stats/iter/mmeanabs2from relative tolerance (EPS-scaled) assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with the associateddelta/tolbookkeeping.Only
test/test.jsis modified; the package has notest/test.native.js. No implementation, fixture, documentation, or benchmark changes are included.ULP bounds
The package has a single relative tolerance assertion, in the moving mean of squared absolute values test:
the function returns an iterator protocol-compliant object which iteratively computes a moving arithmetic mean of squared absolute values11Starting from
64and tightening,1is the smallest bound which still passes. The first three window values (4.0,6.5,17/3) are returned bit-identically, while the remaining three (29/3,29/3,41/3) differ from the expected values by exactly one ULP (e.g.,9.666666666666668vs.9.666666666666666), owing to the incremental accumulation. Re-running the suite at0fails3of185assertions, confirming1is the minimum.The suite was run twice at the final bound, passing
185/185both times, andeslintagainstetc/eslint/.eslintrc.tests.jsreports no findings.For reference, the sibling package
stats/incr/mmeanabs2also settled on1.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verified locally with
make test TESTS_FILTER=".*/stats/iter/mmeanabs2/.*"andmake lint-javascript-tests TESTS_FILTER=".*/stats/iter/mmeanabs2/.*".Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which selected the package, studied already-migrated packages to match the established idiom, performed the migration, and searched for the minimum passing ULP bound by measurement.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01REEty7dbxKciFfLkvMt3K6
Generated by Claude Code