Repository navigation
chore: clean-up - #15425
Merged
Merged
chore: clean-up#15425
Conversation
Resolve `lib/main.js` require with an explicit `.js` extension, as required by `stdlib/require-file-extensions`, and import the local declarations in `docs/types/test.ts` rather than the package path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPx5veUPahKt8Gwe8N4MdA
…ided1d/blocked` The nine API headings named `strideY`/`strideZ`, while the parameter lists below them and the `lib/*.js` JSDoc use `stridesY`/`stridesZ`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPx5veUPahKt8Gwe8N4MdA
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
marked this pull request as ready for review
September 22, 2026 15:39
kgryte
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-09-21 18:41 PDT (1e6660288) and 2026-09-22 03:35 PDT (a75d488c1).Description
This pull request:
5dad2c572,lib/node_modules/@stdlib/blas/ext/base/ztril2triu/lib/main.js(L24) requires./ztril2triuwithout the.jsextension, violatingstdlib/require-file-extensions; fix to./ztril2triu.jsto matchdtril2triu,ctriu2tril,dtriu2tril, etc.blas/ext/base/ztril2triu'sdocs/types/test.ts(introduced in5dad2c572) torequire( './index' )instead of the package path, so the test actually type-checks the localindex.d.ts.stridesY/stridesZmistyped asstrideY/strideZin all nine API headings oflib/node_modules/@stdlib/ndarray/base/kernels/generic/binary-strided1d/blocked/README.md(introduced in5f6b7b358); fixed to match the parameter lists and2d.jsJSDoc (same typo exists in theunblockedsibling's README, left out of scope here).Grouped by package, one commit each:
blas/ext/base/ztril2triu—style:(both module-path fixes)ndarray/base/kernels/generic/binary-strided1d/blocked—docs:Both new
ztril2triudefects were inherited from the pre-existingztril, which the package was templated from;ztril/ztriucarry the same two deviations but are outside this window and were left alone.Related Issues
No.
Questions
No.
Other
Window reviewed. 31 commits, 210 files. 24 are
test:migrations to ULP-based assertions (issue #11352), 4 are new packages (blas/ext/base/{ctril2triu,ztril2triu,ztriu2tril},ndarray/base/kernels/generic/binary-strided1d/blocked), 3 are misc (a3e346300whitespace,4ef16a954API_SUFFIXREADME cleanup,ef08b9f5ahypergeometric/variance refactor).Validation. Checked: style-guide compliance of each new package against its established sibling (
dtril2triu,ctriu2tril,dtriu2tril,unary-strided1d/blocked,binary-strided1d/unblocked); copy-paste contamination across dtype variants and across the ninelib/{2..10}d.jskernels; bug scan over the union diff; memory safety and argv ordering in the newsrc/main.c/src/addon.c; leftover dead declarations across all 80 touched test files.Came back clean and deliberately not changed:
ef08b9f5arewrites hypergeometric variance asp = K/N; n*p*(1-p)*((N-n)/(N-1)).(N-K)/Nand1.0-pare not bit-identical, but the rewrite matches the package's existing C implementation and reduces max error against the Julia fixtures from 29 ULP to 1, consistent with the newisAlmostSameValue( y, expected[ i ], 1 )tolerance. Correct as written.src/main.candlib/base.jsis logic-identical to the established siblings; fuzzed against a naive reference over random stride/offset/kconfigurations with no mismatches.binary-strided1d/unblockedfor ndims 2–10 in both memory orders, including shapes large enough to force block splits.var delta/tol/abs/EPSdeclarations or unused requires left behind by the ULP migrations.Deliberately excluded from this PR: the identical
strideY/strideZtypo inbinary-strided1d/unblocked/README.mdand the same two module-path deviations inblas/ext/base/{ztril,ztriu}— all outside the commit window. Also excluded: anything requiring interpretation or a judgment call, and any fix that would have needed changes beyond the window's diff to stay correct.Note:
node_modulesis not installed in the environment this ran in, so the package test suites could not be executed.lib/main.jswas verified to load under Node after the require change; the other two edits are a TypeScript import path and README headings.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as a scheduled review of the last 24 hours of commits to
develop. Claude enumerated the commit window, ran parallel style and bug reviews against established reference packages, cross-verified each finding against the repository before accepting it, and applied the fixes. Every change here is a one-line module path or a documentation typo; the analysis summarized above under "Validation" is likewise AI-generated and should be spot-checked rather than taken on trust. Opened as a draft for maintainer audit.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01WPx5veUPahKt8Gwe8N4MdA
Generated by Claude Code