Repository navigation
test: migrate stats/incr/mrmse to ULP-based assertions - #15424
Conversation
Replaces the relative tolerance (`EPS`-scaled) assertion in the moving RMSE accumulator test with a ULP-based assertion using `@stdlib/assert/is-almost-same-value`, and drops the now unused `abs` and `EPS` requires. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HQgrpZaysJsUnYF5azzXaB
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Resolves a part of #11352.
Description
This pull request:
@stdlib/stats/incr/mrmsefrom relative tolerance (EPS-scaled) assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with the associateddelta/tolbookkeeping.Only
test/test.jsis modified; the package has notest/test.native.js. No implementation, fixture, documentation, or benchmark changes are included.ULP bounds
The package has a single relative tolerance assertion, in the moving RMSE accumulator test:
the accumulator function computes a moving root mean squared error incrementally00Starting from
64and tightening,0still passes: the accumulator returns bit-identical results to the expected values (sqrt( 17/2 ),sqrt( 26/3 ),sqrt( 89/3 ),sqrt( 82/3 ),sqrt( 154/3 ), and1.0) for every case, so no looser bound is warranted. The suite was run twice at the final bound, passing98/98both times, andeslintagainstetc/eslint/.eslintrc.tests.jsreports no findings.For reference, the sibling package
stats/incr/rmsealso settled on0.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verified locally with
make test TESTS_FILTER=".*/stats/incr/mrmse/.*".Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which selected the package, studied already-migrated packages to match the established idiom, performed the migration, and searched for the minimum passing ULP bound by measurement.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01HQgrpZaysJsUnYF5azzXaB
Generated by Claude Code