Repository navigation
Conversation
Replaces http://www.speech.cs.cmu.edu/cgi-bin/cmudict#about with a Wayback Machine archived snapshot. The original URL only supports HTTP, but GitHub's markdown-link-check workflow defaults to HTTPS, causing the link to be reported as broken (HTTP 0). Routing through web.archive.org preserves the original content while satisfying the HTTPS-only link checker. Fixes stdlib-js#11868
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Closing to consolidate my open pull requests across repositories — this is not a problem with the fix, which is a one-line replacement of an HTTP-only CMUdict URL with an archived snapshot. The bot flagged that the contributing-guidelines acknowledgement checkbox was missing; that is a one-minute body edit, but I am not able to create pull requests against this repository from my current API token (all create attempts return 404/403), so I cannot update the body. If a maintainer wants this trivial doc fix, it takes the same edit by hand: replace the broken link in lib/node_modules/@stdlib/datasets/cmudict/README.md with https://web.archive.org/web/2023/https://www.speech.cs.cmu.edu/cgi-bin/cmudict#about . Branch and commit are preserved on my fork. |
Description
Fixes #11868
Replaces the broken link \http://www.speech.cs.cmu.edu/cgi-bin/cmudict#about\ in \lib/node_modules/@stdlib/datasets/cmudict/README.md\ with a Wayback Machine archived snapshot.
Root cause
The original URL only supports HTTP, but GitHub's automated markdown-link-check workflow defaults to HTTPS, which causes the link to be reported as broken (HTTP Status: 0 Failed). Routing through \web.archive.org\ preserves the original content while satisfying the HTTPS-only link checker.
Approach
Verification
Resolves #11868