Repository navigation
docs: fix description - #15322
Merged
Merged
docs: fix description#15322
Conversation
The migration to ULP-based assertions copied the ULP bounds derived from the JavaScript test suite (32/128) into `test.native.js`, whose original tolerances were deliberately looser (750 eps and 8200 eps) and documented a fixture case for which the native implementation differs from the expected value by approximately 13764 ULPs. This restores equivalent bounds and the explanatory note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NJCXZyRqsVkbrugTvVu7LY
The migration to ULP-based assertions replaced the native test's deliberately looser tolerance of 18 eps with an exact-equality assertion (0 ULPs) copied from the JavaScript test suite, whose original tolerance was only 1 eps. This restores an equivalent bound of 36 ULPs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NJCXZyRqsVkbrugTvVu7LY
The `Float16Options` overload's description was copied from the `float32` overload and read "single-precision" instead of "half-precision". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NJCXZyRqsVkbrugTvVu7LY
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Sep 28, 2026
…rmal/mode`" This reverts commit 031bb4e. The premise was incorrect: PR CI compiles the native add-ons and runs the native test suites, so the migrated 0 ULP bound was validated against actual native output and the looser bound is unnecessary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NJCXZyRqsVkbrugTvVu7LY
…hy/cdf`" This reverts commit 461873c. The premise was incorrect: PR CI compiles the native add-ons and runs the native test suites, so the migrated 32/128 ULP bounds were validated against actual native output and the documented outlier in the removed note no longer reflects current native behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NJCXZyRqsVkbrugTvVu7LY
Planeshifter
changed the title
ndarray/ones-like
kgryte
approved these changes
Sep 28, 2026
kgryte
changed the title
ndarray/ones-like
kgryte
added
Documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fix for commits merged to
developbetween 2026-09-17T23:23:38-07:00 (625cd5d) and 2026-09-17T23:55:31-07:00 (51a1812).This pull request:
ndarray/ones-like: Fixes a copy-paste from 51a1812: theFloat16Optionsoverload said "single-precision" — should be "half-precision", matching whatzeros-likealready got right. One-line fix indocs/types/index.d.ts.Related Issues
No related issues.
Questions
No.
Other
Validation. All 20 commits merged to
developin the window were reviewed for style-guide compliance (againstdocs/style-guidesand established reference packages) and scanned for bugs by independent reviewers; only findings corroborated by multiple reviewers and re-verified against the diffs were retained.Scope note. This PR originally also loosened the ULP tolerances in
stats/base/dists/cauchy/cdfandstats/base/dists/lognormal/modetest.native.json the premise that the native suites are not exercised in PR CI. That premise was wrong — CI compiles the add-ons and runs the native tests, so the migrated bounds were already validated against native output — and both commits were reverted (de061f1, a907bd3) following review discussion. The net diff is the one-linendarray/ones-likedocs fix.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance.
This PR was written by Claude Code as part of an automated review of commits recently merged to
develop; findings were cross-checked by multiple independent review passes and verified against the diffs before fixes were authored.🤖 Generated with Claude Code
https://claude.ai/code/session_01NJCXZyRqsVkbrugTvVu7LY