Skip to content

test: migrate lapack/base/crot to ULP-based assertions #15205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Planeshifter merged 6 commits into from
Sep 22, 2026
Merged

test: migrate lapack/base/crot to ULP-based assertions #15205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca18acd
test: migrate `lapack/base/crot` to ULP-based assertions
claude Sep 13, 2026
1361874
Merge remote-tracking branch 'upstream/develop' into kgryte/ulp-crot
stdlib-bot Sep 22, 2026
3bc0361
style: inline ULP values and remove isApprox helper
Planeshifter Sep 22, 2026
f844f9d
style: add missing blank lines before section headers
Planeshifter Sep 22, 2026
fb5508f
revert: restore isApprox helper with inline ULP literals
Planeshifter Sep 22, 2026
9f3fa65
style: fix blank lines before section headers
Planeshifter Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 20 additions & 29 deletions lib/node_modules/@stdlib/lapack/base/crot/test/test.crot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ var tape = require( 'tape' );
var Float32Array = require( '@stdlib/array/float32' );
var Complex64Array = require( '@stdlib/array/complex64' );
var Complex64 = require( '@stdlib/complex/float32/ctor' );
var EPS = require( '@stdlib/constants/float32/eps' );
var absf = require( '@stdlib/math/base/special/absf' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var crot = require( './../lib/crot.js' );


Expand All @@ -38,22 +37,14 @@ var crot = require( './../lib/crot.js' );
* @param {Object} t - test object
* @param {Collection} actual - actual values
* @param {Collection} expected - expected values
* @param {number} rtol - relative tolerance
* @param {NonNegativeInteger} ulp - maximum allowed ULP difference
*/
function isApprox( t, actual, expected, rtol ) {
var delta;
var tol;
function isApprox( t, actual, expected, ulp ) {
var i;

t.strictEqual( actual.length, expected.length, 'returns expected value' );
for ( i = 0; i < expected.length; i++ ) {
if ( actual[ i ] === expected[ i ] ) {
t.strictEqual( actual[ i ], expected[ i ], 'returns expected value' );
} else {
delta = absf( actual[ i ] - expected[ i ] );
tol = rtol * EPS * absf( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. actual: '+actual[ i ]+'. expected: '+expected[ i ]+'. delta: '+delta+'. tol: '+tol+'.' );
}
t.strictEqual( isAlmostSameValuef( actual[ i ], expected[ i ], ulp ), true, 'returns expected value' );
}
}

Expand Down Expand Up @@ -130,8 +121,8 @@ tape( 'the function applies a plane rotation', function test( t ) {
]);

out = crot( cx.length, cx, 1, cy, 1, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 2.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 1 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -195,8 +186,8 @@ tape( 'the function applies a plane rotation', function test( t ) {
]);

out = crot( cx.length, cx, 1, cy, 1, 1.25, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 2.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 0 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -260,8 +251,8 @@ tape( 'the function applies a plane rotation', function test( t ) {
]);

out = crot( cx.length, cx, 1, cy, 1, 1.25, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 4.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 5 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -323,8 +314,8 @@ tape( 'the function supports an `x` stride', function test( t ) {
]);

out = crot( 2, cx, 2, cy, 1, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 4.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 5 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -386,8 +377,8 @@ tape( 'the function supports a `y` stride', function test( t ) {
]);

out = crot( 2, cx, 1, cy, 2, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 2.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 1 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -495,8 +486,8 @@ tape( 'the function supports negative strides', function test( t ) {
]);

out = crot( 2, cx, -1, cy, -2, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 2.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 1 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -558,8 +549,8 @@ tape( 'the function supports complex access patterns', function test( t ) {
]);

out = crot( 2, cx, 2, cy, -1, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 4.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 5 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -629,8 +620,8 @@ tape( 'the function supports view offsets', function test( t ) {
]);

out = crot( 2, cx1, -2, cy1, 1, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 4.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 5 );
t.strictEqual( out, cy1, 'returns expected value' );
t.end();
});
45 changes: 18 additions & 27 deletions lib/node_modules/@stdlib/lapack/base/crot/test/test.ndarray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ var tape = require( 'tape' );
var Float32Array = require( '@stdlib/array/float32' );
var Complex64Array = require( '@stdlib/array/complex64' );
var Complex64 = require( '@stdlib/complex/float32/ctor' );
var EPS = require( '@stdlib/constants/float32/eps' );
var absf = require( '@stdlib/math/base/special/absf' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var crot = require( './../lib/ndarray.js' );


Expand All @@ -38,22 +37,14 @@ var crot = require( './../lib/ndarray.js' );
* @param {Object} t - test object
* @param {Collection} actual - actual values
* @param {Collection} expected - expected values
* @param {number} rtol - relative tolerance
* @param {NonNegativeInteger} ulp - maximum allowed ULP difference
*/
function isApprox( t, actual, expected, rtol ) {
var delta;
var tol;
function isApprox( t, actual, expected, ulp ) {
var i;

t.strictEqual( actual.length, expected.length, 'returns expected value' );
for ( i = 0; i < expected.length; i++ ) {
if ( actual[ i ] === expected[ i ] ) {
t.strictEqual( actual[ i ], expected[ i ], 'returns expected value' );
} else {
delta = absf( actual[ i ] - expected[ i ] );
tol = rtol * EPS * absf( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. actual: '+actual[ i ]+'. expected: '+expected[ i ]+'. delta: '+delta+'. tol: '+tol+'.' );
}
t.strictEqual( isAlmostSameValuef( actual[ i ], expected[ i ], ulp ), true, 'returns expected value' );
}
}

Expand Down Expand Up @@ -129,8 +120,8 @@ tape( 'the function applies a plane rotation', function test( t ) {
]);

out = crot( cx.length, cx, 1, 0, cy, 1, 0, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 2.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 1 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -192,8 +183,8 @@ tape( 'the function supports an `x` stride', function test( t ) {
]);

out = crot( 2, cx, 2, 0, cy, 1, 0, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 2.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 1 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -255,8 +246,8 @@ tape( 'the function supports an `x` offset', function test( t ) {
]);

out = crot( 3, cx, 1, 1, cy, 1, 0, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 4.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 5 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -318,8 +309,8 @@ tape( 'the function supports a `y` stride', function test( t ) {
]);

out = crot( 2, cx, 1, 0, cy, 2, 0, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 2.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 1 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -381,8 +372,8 @@ tape( 'the function supports a `y` offset', function test( t ) {
]);

out = crot( 2, cx, 2, 0, cy, -1, 1, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 4.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 5 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -490,8 +481,8 @@ tape( 'the function supports negative strides', function test( t ) {
]);

out = crot( 2, cx, -1, 1, cy, -2, 2, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 2.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 1 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -553,8 +544,8 @@ tape( 'the function supports complex access patterns', function test( t ) {
]);

out = crot( 2, cx, 2, 1, cy, 1, 2, 0.8, s );
isApprox( t, viewX, cxe, 2.0 );
isApprox( t, viewY, cye, 4.0 );
isApprox( t, viewX, cxe, 0 );
isApprox( t, viewY, cye, 5 );
t.strictEqual( out, cy, 'returns expected value' );
t.end();
});
Loading