Skip to content

style: add whitespace - #15184

Merged
kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-09-12
Sep 15, 2026
Merged

kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-09-12

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • provides follow-up fixes for commits merged to develop between 2026-09-11 10:23 PDT (10a84e4) and 2026-09-12 00:43 PDT (c88d3f4)
  • fixes the array-index spacing in 6224797: expected[i] → expected[ i ] across the nine new assertion lines in stats/base/dists/uniform/pdf/test/test.factory.js, test/test.native.js, and test/test.pdf.js, matching sibling ULP-migration commits and the style guide
  • fixes the bracket spacing in _tools/github/rank-users/lib/shuffle.js: sorted[i][0] → sorted[ i ][ 0 ]. 10a84e4 fixed this same pattern in blas/base/drotg and stats/ttest but missed this line

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

All 12 commits merged to develop in the review window were audited for bugs and stdlib style-guide compliance (independent style and bug review passes over the union and per-commit diffs; migrated tests were re-run). Only objective, in-diff issues were retained: findings on unchanged context lines, subjective suggestions, and anything reverting deliberate choices (e.g. the [] + push() rewrite in rank-users/lib/shuffle.js) were deliberately excluded. Affected uniform/pdf tests pass after the change.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written by Claude Code as part of an automated daily review of commits merged to develop; a human maintainer will audit before promoting it from draft.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Re27E1SsN9jErvG9tU8e75


Generated by Claude Code

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/uniform/pdf $\\color{green}287/287$
$\\color{green}+100.00\\%$
$\\color{green}25/25$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}287/287$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Copy link
Copy Markdown
Member Author

The Run affected tests failure is not caused by this PR. The diff's only non-test change is whitespace inside _tools/github/rank-users/lib/shuffle.js, which triggered the dependent package _tools/github/rank-followers to run its tests, and two assertions in test/test.cli.js (lines 299 and 379) fail identically on both runs of this check:

  • the tests stub ./../lib and assert that opts.format / opts.delimiter are forwarded to rank(), but bin/cli deliberately consumes --format and --delimiter locally to select and parametrize the output writer and never forwards them, so actual is always undefined;
  • the format fixture passes --format=json while the test expects 'csv', so the assertion could not pass even with forwarding.

These assertions cannot ever have passed; they only surface when something touches these rarely-changed _tools packages. The same copy-pasted assertions exist in _tools/github/rank-users/test/test.cli.js (including out.method === 'followers' in the rank-users tests).

Proposed fix (kept out of this PR to avoid widening it beyond the 24-hour review window): drop the format and delimiter forwarding assertions in both packages' test/test.cli.js, or rewrite them to assert observable CLI behavior instead (JSON written to stdout for --format=json; the delimiter appearing in CSV rows for --delimiter=';').


Generated by Claude Code

@kgryte
kgryte marked this pull request as ready for review September 15, 2026 07:35
@kgryte
kgryte requested a review from a team September 15, 2026 07:35
@kgryte

kgryte commented Sep 15, 2026

Copy link
Copy Markdown
Member

As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte changed the title style: fix array index spacing in recently merged commits style: add whitespace Sep 15, 2026
@kgryte
kgryte merged commit 46409dc into develop Sep 15, 2026
16 of 18 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-09-12 branch September 15, 2026 07:37
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants