Skip to content

chore: fix inconsistencies across packages in blas/ext/base* - #15146

Merged
kgryte merged 83 commits into
stdlib-js:developfrom
headlessNode:blas/ref/index
Sep 29, 2026
Merged

kgryte merged 83 commits into
stdlib-js:developfrom
headlessNode:blas/ref/index

Conversation

@headlessNode

@headlessNode headlessNode commented Sep 10, 2026 •

Copy link
Copy Markdown
Member

Resolves stdlib-js/metr-issue-tracker#1316.

Description

What is the purpose of this pull request?

This pull request fixes inconsistencies across the index-returning packages in blas/ext/base. For each family, a canonical structure and wording was established from the family's most consistent member and applied to all siblings.

Bird's eye view of the changes:

  • Tests: refactored test tapes to a canonical structure: single-assertion main behavior tapes; separate tapes for an x (and y) stride, negative strides, view offsets (main), and index offsets (ndarray), each with accessor twins in g packages; added missing tapes (offsets, complex accessors, arity, no-match -1, NaN comparison); normalized tape titles, data, and spacing; removed redundant tapes flagged in review.
  • REPL: normalized example section labels (// Standard usage:, // Using `N` and stride parameters:, // Using view offsets:, // Using index offset(s):), added missing stride/offset example blocks, var only on the first assignment within a section, wrapped description text consistently, and fixed lines exceeding the 80-character render limit.
  • READMEs: normalized Notes wording (NaN/-0/+0 comparison notes, the "If the function is unable to find ... the function returns -1." usage sentence, N <= 0 first Notes bullet), parameter bullet style and stride/offset parameter descriptions ("stride length for ...", "starting index for ..."), example data and comment styles across siblings, and restored missing template comments.
  • TypeScript declarations and tests: notes parity in index.d.ts, added missing $ExpectError cases (e.g., function arguments), normalized arity-block arguments, and added missing complex-array imports.
  • Library JSDoc: notes parity across lib/*.js files (including .native.js), normalized descriptions and parameter wording, and added matrix visualization comments per family canon.
  • C sources: aligned @param comment spacing in src/main.c, normalized NAPI macro ordering in src/addon.c, canonical comments in examples/c/example.c and README C sections (// Perform a search:, printf( "index value: %d\n", idx )), const input arrays, and parameter wording in doc comments.
  • Examples and benchmarks: logEach-based logging for complex input arrays, normalized data generation ranges, and corrected benchmark require paths and helper naming.
  • package.json: normalized descriptions and keywords per family conventions.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.


@stdlib-js/reviewers

@headlessNode
headlessNode requested a review from a team September 10, 2026 14:17
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Sep 10, 2026
@headlessNode

Copy link
Copy Markdown
Member Author

@kgryte This ended up being a lot bigger than I expected. The 'fixes' are mostly docs and tests related. I will updated the currently open related PR's as well.

@stdlib-bot

stdlib-bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/cindex-of $\\color{green}404/404$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}404/404$
$\\color{green}+0.00\\%$
blas/ext/base/cindex-of-column $\\color{green}560/560$
$\\color{green}+0.00\\%$
$\\color{green}51/51$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}560/560$
$\\color{green}+0.00\\%$
blas/ext/base/cindex-of-falsy $\\color{green}394/394$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}394/394$
$\\color{green}+0.00\\%$
blas/ext/base/cindex-of-row $\\color{green}560/560$
$\\color{green}+0.00\\%$
$\\color{green}51/51$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}560/560$
$\\color{green}+0.00\\%$
blas/ext/base/cindex-of-truthy $\\color{green}394/394$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}394/394$
$\\color{green}+0.00\\%$
blas/ext/base/clast-index-of-row $\\color{green}613/613$
$\\color{green}+0.00\\%$
$\\color{green}49/49$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}613/613$
$\\color{green}+0.00\\%$
blas/ext/base/dfirst-index-equal $\\color{green}388/388$
$\\color{green}+0.00\\%$
$\\color{green}18/18$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}388/388$
$\\color{green}+0.00\\%$
blas/ext/base/dfirst-index-greater-than $\\color{green}388/388$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}388/388$
$\\color{green}+0.00\\%$
blas/ext/base/dfirst-index-less-than $\\color{green}388/388$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}388/388$
$\\color{green}+0.00\\%$
blas/ext/base/dindex-of $\\color{green}373/373$
$\\color{green}+0.00\\%$
$\\color{green}18/18$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}373/373$
$\\color{green}+0.00\\%$
blas/ext/base/dindex-of-column $\\color{green}543/543$
$\\color{green}+0.00\\%$
$\\color{green}49/49$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}543/543$
$\\color{green}+0.00\\%$
blas/ext/base/dindex-of-falsy $\\color{green}373/373$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}373/373$
$\\color{green}+0.00\\%$
blas/ext/base/dindex-of-not-equal $\\color{green}373/373$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}373/373$
$\\color{green}+0.00\\%$
blas/ext/base/dindex-of-row $\\color{green}543/543$
$\\color{green}+0.00\\%$
$\\color{green}49/49$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}543/543$
$\\color{green}+0.00\\%$
blas/ext/base/dindex-of-truthy $\\color{green}373/373$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}373/373$
$\\color{green}+0.00\\%$
blas/ext/base/dlast-index-equal $\\color{green}398/398$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}398/398$
$\\color{green}+0.00\\%$
blas/ext/base/dlast-index-of $\\color{green}379/379$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}379/379$
$\\color{green}+0.00\\%$
blas/ext/base/dlast-index-of-falsy $\\color{green}380/380$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}380/380$
$\\color{green}+0.00\\%$
blas/ext/base/dlast-index-of-row $\\color{green}587/587$
$\\color{green}+0.00\\%$
$\\color{green}47/47$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}587/587$
$\\color{green}+0.00\\%$
blas/ext/base/dlast-index-of-truthy $\\color{green}380/380$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}380/380$
$\\color{green}+0.00\\%$
blas/ext/base/gfind-index $\\color{green}283/283$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}283/283$
$\\color{green}+0.00\\%$
blas/ext/base/gfind-last-index $\\color{green}200/200$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}200/200$
$\\color{green}+0.00\\%$
blas/ext/base/gfirst-index-almost-equal $\\color{green}293/293$
$\\color{green}+0.00\\%$
$\\color{green}21/21$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}293/293$
$\\color{green}+0.00\\%$
blas/ext/base/gfirst-index-almost-same-value $\\color{green}293/293$
$\\color{green}+0.00\\%$
$\\color{green}21/21$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}293/293$
$\\color{green}+0.00\\%$
blas/ext/base/gfirst-index-equal $\\color{green}284/284$
$\\color{green}+0.00\\%$
$\\color{green}23/23$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}284/284$
$\\color{green}+0.00\\%$
blas/ext/base/gfirst-index-greater-than $\\color{green}284/284$
$\\color{green}+0.00\\%$
$\\color{green}21/21$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}284/284$
$\\color{green}+0.00\\%$
blas/ext/base/gfirst-index-greater-than-equal $\\color{green}284/284$
$\\color{green}+0.00\\%$
$\\color{green}21/21$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}284/284$
$\\color{green}+0.00\\%$
blas/ext/base/gfirst-index-less-than $\\color{green}284/284$
$\\color{green}+0.00\\%$
$\\color{green}21/21$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}284/284$
$\\color{green}+0.00\\%$
blas/ext/base/gfirst-index-less-than-equal $\\color{green}284/284$
$\\color{green}+0.00\\%$
$\\color{green}21/21$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}284/284$
$\\color{green}+0.00\\%$
blas/ext/base/gfirst-index-not-equal $\\color{green}281/281$
$\\color{green}+0.00\\%$
$\\color{green}21/21$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}281/281$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of $\\color{green}260/260$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}260/260$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-almost-same-value $\\color{green}269/269$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}269/269$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-column $\\color{green}554/554$
$\\color{green}+0.00\\%$
$\\color{green}55/55$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}554/554$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-falsy $\\color{green}260/260$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}260/260$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-falsy-row $\\color{green}233/233$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}233/233$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-greater-than $\\color{green}260/260$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}260/260$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-greater-than-equal $\\color{green}260/260$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}260/260$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-less-than $\\color{green}260/260$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}260/260$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-less-than-equal $\\color{green}260/260$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}260/260$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-not-equal $\\color{green}260/260$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}260/260$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-row $\\color{red}470/554$
$\\color{green}+0.00\\%$
$\\color{red}36/37$
$\\color{green}+0.00\\%$
$\\color{red}3/4$
$\\color{green}+0.00\\%$
$\\color{red}470/554$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-same-value $\\color{green}266/266$
$\\color{green}+0.00\\%$
$\\color{green}22/22$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}266/266$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-truthy $\\color{green}260/260$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}260/260$
$\\color{green}+0.00\\%$
blas/ext/base/gindex-of-truthy-row $\\color{green}351/351$
$\\color{green}+0.00\\%$
$\\color{green}43/43$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}351/351$
$\\color{green}+0.00\\%$
blas/ext/base/glast-index-almost-same-value $\\color{green}193/193$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}193/193$
$\\color{green}+0.00\\%$
blas/ext/base/glast-index-equal $\\color{green}191/191$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}191/191$
$\\color{green}+0.00\\%$
blas/ext/base/glast-index-greater-than $\\color{green}191/191$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}191/191$
$\\color{green}+0.00\\%$
blas/ext/base/glast-index-greater-than-equal $\\color{green}191/191$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}191/191$
$\\color{green}+0.00\\%$
blas/ext/base/glast-index-less-than $\\color{green}191/191$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}191/191$
$\\color{green}+0.00\\%$
blas/ext/base/glast-index-not-equal $\\color{green}191/191$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}191/191$
$\\color{green}+0.00\\%$
blas/ext/base/glast-index-of $\\color{green}182/182$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}182/182$
$\\color{green}+0.00\\%$
blas/ext/base/glast-index-of-falsy $\\color{green}182/182$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}182/182$
$\\color{green}+0.00\\%$
blas/ext/base/glast-index-of-row $\\color{green}554/554$
$\\color{green}+0.00\\%$
$\\color{green}53/53$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}554/554$
$\\color{green}+0.00\\%$
blas/ext/base/glast-index-of-truthy $\\color{green}182/182$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}182/182$
$\\color{green}+0.00\\%$
blas/ext/base/sfirst-index-equal $\\color{green}388/388$
$\\color{green}+0.00\\%$
$\\color{green}18/18$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}388/388$
$\\color{green}+0.00\\%$
blas/ext/base/sfirst-index-less-than $\\color{green}388/388$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}388/388$
$\\color{green}+0.00\\%$
blas/ext/base/sindex-of $\\color{green}373/373$
$\\color{green}+0.00\\%$
$\\color{green}18/18$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}373/373$
$\\color{green}+0.00\\%$
blas/ext/base/sindex-of-column $\\color{green}543/543$
$\\color{green}+0.00\\%$
$\\color{green}49/49$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}543/543$
$\\color{green}+0.00\\%$
blas/ext/base/sindex-of-falsy $\\color{green}373/373$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}373/373$
$\\color{green}+0.00\\%$
blas/ext/base/sindex-of-not-equal $\\color{green}373/373$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}373/373$
$\\color{green}+0.00\\%$
blas/ext/base/sindex-of-row $\\color{green}543/543$
$\\color{green}+0.00\\%$
$\\color{green}49/49$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}543/543$
$\\color{green}+0.00\\%$
blas/ext/base/sindex-of-truthy $\\color{green}373/373$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}373/373$
$\\color{green}+0.00\\%$
blas/ext/base/slast-index-equal $\\color{green}398/398$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}398/398$
$\\color{green}+0.00\\%$
blas/ext/base/slast-index-of $\\color{green}379/379$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}379/379$
$\\color{green}+0.00\\%$
blas/ext/base/slast-index-of-falsy $\\color{green}380/380$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}380/380$
$\\color{green}+0.00\\%$
blas/ext/base/slast-index-of-row $\\color{green}587/587$
$\\color{green}+0.00\\%$
$\\color{green}47/47$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}587/587$
$\\color{green}+0.00\\%$
blas/ext/base/slast-index-of-truthy $\\color{green}380/380$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}380/380$
$\\color{green}+0.00\\%$
blas/ext/base/zindex-of $\\color{green}404/404$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}404/404$
$\\color{green}+0.00\\%$
blas/ext/base/zindex-of-column $\\color{green}560/560$
$\\color{green}+0.00\\%$
$\\color{green}51/51$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}560/560$
$\\color{green}+0.00\\%$
blas/ext/base/zindex-of-falsy $\\color{green}394/394$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}394/394$
$\\color{green}+0.00\\%$
blas/ext/base/zindex-of-row $\\color{green}560/560$
$\\color{green}+0.00\\%$
$\\color{green}51/51$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}560/560$
$\\color{green}+0.00\\%$
blas/ext/base/zindex-of-truthy $\\color{green}394/394$
$\\color{green}+0.00\\%$
$\\color{green}20/20$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}394/394$
$\\color{green}+0.00\\%$
blas/ext/base/zlast-index-of-falsy $\\color{green}388/388$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}388/388$
$\\color{green}+0.00\\%$
blas/ext/base/zlast-index-of-row $\\color{green}613/613$
$\\color{green}+0.00\\%$
$\\color{green}49/49$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}613/613$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@headlessNode
headlessNode marked this pull request as draft September 10, 2026 16:55
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 10, 2026
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Sep 22, 2026
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Sep 25, 2026
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/ext/base/gindex-of-greater-than-equal/package.json Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gindex-of-greater-than/package.json Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gindex-of-not-equal/package.json Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/ext/base/gindex-of-same-value/package.json Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/glast-index-of/README.md Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/glast-index-of/README.md Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/glast-index-of/README.md Outdated
kgryte and others added 3 commits September 27, 2026 19:51
var Float64Array = require( '@stdlib/array/float64' );

// Initial arrays...
// Initial arrays:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@headlessNode You are too blindly making changes. The general rule is:

  1. If a comment applies to the next line and next line only, use a colon.
  2. If a comment applies to multiple lines and/or a block of code, use ellipses.

(1) can be loosened for <= 3 consecutive lines if it is "obvious" that all statements belong to the same comment. As such, we can keep this change; however, to minimize future noise, it is useful to remember the guidance above.

}

// Attached to main export is an `ndarray` method which returns a number...
// Attached to the main export is an `ndarray` method which returns a number...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Looks like this was a false flag. I checked elsewhere in the codebase (other namespaces). And consistently we use Attached to main export. So, no need to deviate here. You can revert everything back to Attached to main export. Sorry for the noise.

@headlessNode

Copy link
Copy Markdown
Member Author

Np. Fixed the ellipses/colon one as well.

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I went through all the files. Things look fine. A significant amount of technical debt had accumulated, so getting this in sooner rather than later will be good for mitigating further spread.

@headlessNode You may want to check your current PRs once this is merged, as some of those may also need updating.

@kgryte

kgryte commented Sep 29, 2026

Copy link
Copy Markdown
Member

As the CI failure is expected, I'll go ahead and merge.

@kgryte kgryte changed the title refactor: fix inconsistencies across packages in blas/ext/base* chore: fix inconsistencies across packages in blas/ext/base* Sep 29, 2026
@kgryte
kgryte merged commit 67c1633 into stdlib-js:develop Sep 29, 2026
11 of 13 checks passed
@headlessNode
headlessNode deleted the blas/ref/index branch September 29, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). METR Pull request associated with the METR project. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: fix inconsistencies across packages in blas/ext/base*

3 participants