Skip to content

chore: fix JavaScript lint errors (issue #11784) - #15092

Open
AlvaroBalbin wants to merge 1 commit into
stdlib-js:developfrom
AlvaroBalbin:fix/11784-fix-javascript-lint-errors
Open

AlvaroBalbin wants to merge 1 commit into
stdlib-js:developfrom
AlvaroBalbin:fix/11784-fix-javascript-lint-errors

Conversation

@AlvaroBalbin

@AlvaroBalbin AlvaroBalbin commented Sep 8, 2026 •

Copy link
Copy Markdown

The issue-creation helper calls toISOString() even when the response has no rate-limit reset header. That throws RangeError: Invalid time value and hides the original request error reported in #11784.

This guards the date formatting when the parsed reset value is NaN. The regression test supplies empty response headers and checks that the callback receives the original request error.

Related Issues: resolves #11784.

The new contributing-guidelines acceptance check passes. Upstream workflow execution still needs maintainer approval; I have not rerun the full upstream suite during this audit.

AI assistance was used to prepare this contribution and this update.

@AlvaroBalbin
AlvaroBalbin requested a review from a team September 8, 2026 03:30
@stdlib-bot stdlib-bot added the Tools Issue or pull request related to project tooling. label Sep 8, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. and removed First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Sep 8, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@AlvaroBalbin AlvaroBalbin changed the title fix(create-issue): fix JavaScript lint errors chore: fix JavaScript lint errors (issue #11784) Oct 21, 2026
@AlvaroBalbin

Copy link
Copy Markdown
Author

The contributing-guidelines acknowledgment is now included and its check passes. @stdlib-js/reviewers, could you approve the pending workflows and review this fix when convenient?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants