Repository navigation
chore: fix JavaScript lint errors (issue #11784) - #15092
AlvaroBalbin wants to merge 1 commit into
Conversation
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
The contributing-guidelines acknowledgment is now included and its check passes. @stdlib-js/reviewers, could you approve the pending workflows and review this fix when convenient? |
The issue-creation helper calls
toISOString()even when the response has no rate-limit reset header. That throwsRangeError: Invalid time valueand hides the original request error reported in #11784.This guards the date formatting when the parsed reset value is NaN. The regression test supplies empty response headers and checks that the callback receives the original request error.
Related Issues: resolves #11784.
The new contributing-guidelines acceptance check passes. Upstream workflow execution still needs maintainer approval; I have not rerun the full upstream suite during this audit.
AI assistance was used to prepare this contribution and this update.