Skip to content

chore: clean-up - #14905

Merged
kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-09-02
Sep 3, 2026
Merged

kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-09-02

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Sep 2, 2026 •

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-09-01 16:38 (PT) (fd6046b) and 2026-09-02 01:39 (PT) (0c7f769).

This pull request:

  • stats/base/dists/arcsine/logcdf:
    • Fixed malformed return statement in .../arcsine/logcdf/src/main.c:56 (94b9253): double space after LN2, spurious spaces before stdlib_base_asin/stdlib_base_sqrt parens, redundant outer parens, and trailing space before ;. Now matches call-spacing conventions and the JS implementation.
  • stats/base/dists/truncated-normal/pdf:
    • Fixed extra blank line before the C signature code fence in stats/base/dists/truncated-normal/pdf/README.md, introduced in ad203e8; brings it in line with every other dists README (single blank line).
    • Fixed the Doxygen summary line-wrapping in ad203e8 for stats/base/dists/truncated-normal/pdf: joined the hard-wrapped summary in src/main.c and include/stdlib/stats/base/dists/truncated-normal/pdf.h back onto a single line, matching every other stats/base/dists header/source in the repo (text otherwise unchanged).
    • Fixed manifest.json indentation for stats/base/dists/truncated-normal/pdf (ad203e8) from 4 spaces to 2, matching every sibling stats/base/dists manifest; content unchanged, verified via parse-compare.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 18 commits merged to develop in the review window were audited for (1) stdlib style-guide compliance (compared against established reference packages, e.g. laplace/pdf, gamma/pdf, dlast-index-equal/glast-index-equal) and (2) objective bugs within the diffs (formula transcription, addon arity/order, manifest deps vs. includes, search/stride logic, ULP assertion argument order). Deliberately excluded: subjective suggestions, style preferences not required by the style guides, and anything whose fix would require touching code outside the window's diffs (e.g., a latent NaN-parameter edge case in truncated-normal/pdf where the new C code exactly mirrors the pre-existing JS implementation — fixing C alone would break JS/C parity).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated review of commits recently merged to develop; all fixes were machine-proposed, cross-validated against reference packages, and applied verbatim.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MUki2X3AUoN8xkpLKCKKMt


Generated by Claude Code

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Sep 2, 2026
@stdlib-bot

stdlib-bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/arcsine/logcdf $\\color{green}309/309$
$\\color{green}+0.00\\%$
$\\color{green}27/27$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}309/309$
$\\color{green}+0.00\\%$
stats/base/dists/truncated-normal/pdf $\\color{red}295/330$
$\\color{green}+0.00\\%$
$\\color{green}15/15$
$\\color{green}+0.00\\%$
$\\color{red}2/3$
$\\color{green}+0.00\\%$
$\\color{red}295/330$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter

Copy link
Copy Markdown
Member Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Sep 2, 2026
Comment thread lib/node_modules/@stdlib/stats/base/dists/erlang/pdf/README.md Outdated
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Sep 2, 2026
@stdlib-js stdlib-js deleted a comment from stdlib-bot Sep 2, 2026
@Planeshifter
Planeshifter requested a review from kgryte September 2, 2026 18:42
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 2, 2026
@Planeshifter
Planeshifter marked this pull request as ready for review September 2, 2026 18:42
@Planeshifter
Planeshifter requested a review from a team September 2, 2026 18:42
@kgryte kgryte changed the title chore: fix style and documentation nits in recently merged commits chore: clean-up Sep 3, 2026
@kgryte
kgryte merged commit 74f00ef into develop Sep 3, 2026
37 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-09-02 branch September 3, 2026 03:23
@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. and removed Needs Review A pull request which needs code review. labels Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements, additions, or changes to documentation. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants