Skip to content

feat: add C implementation for stats/base/dists/negative-binomial/quantile - #14730

Merged
Planeshifter merged 6 commits into
developfrom
philipp/negative-binomial-quantile-c
Oct 6, 2026
Merged

feat: add C implementation for stats/base/dists/negative-binomial/quantile#14730
Planeshifter merged 6 commits into
developfrom
philipp/negative-binomial-quantile-c

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Resolves #3767.

Description

What is the purpose of this pull request?

This pull request:

  • adds a C implementation for @stdlib/stats/base/dists/negative-binomial/quantile

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

This PR is stacked on #14729, as the implementation depends on the C implementation of @stdlib/stats/base/dists/negative-binomial/cdf.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code; all tests, benchmarks, and examples were built and run locally.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Aug 28, 2026
@stdlib-bot

stdlib-bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@Planeshifter Planeshifter added the METR Pull request associated with the METR project. label Aug 28, 2026
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Aug 28, 2026
@stdlib-bot

stdlib-bot commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/negative-binomial/quantile $\\color{green}528/528$
$\\color{green}+0.38\\%$ 		$\\color{green}62/62$
$\\color{green}+1.64\\%$ 		$\\color{green}6/6$
$\\color{green}+0.00\\%$ 		$\\color{green}528/528$
$\\color{green}+0.38\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review August 28, 2026 04:08
@Planeshifter
Planeshifter requested a review from a team August 28, 2026 04:08
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 28, 2026
@Planeshifter Planeshifter mentioned this pull request Aug 28, 2026
Merged
5 of 7 tasks
kgryte pushed a commit that referenced this pull request Aug 28, 2026
@Planeshifter
fix: prevent non-terminating searches in `stats/base/dists/negative-b…
6d86f29 
…inomial/quantile`

PR-URL: #14733
Reviewed-by: Athan Reines <kgryte@gmail.com>
Ref: stdlib-js/metr-issue-tracker#1227
Ref: #14730
@anandkaranubc anandkaranubc mentioned this pull request Oct 2, 2026
Open
anandkaranubc pushed a commit that referenced this pull request Oct 5, 2026
@Planeshifter
fix: prevent non-terminating searches in `stats/base/dists/negative-b…
93ffd72 
…inomial/quantile`

PR-URL: #14733
Reviewed-by: Athan Reines <kgryte@gmail.com>
Ref: stdlib-js/metr-issue-tracker#1227
Ref: #14730
@anandkaranubc
anandkaranubc force-pushed the philipp/negative-binomial-quantile-c branch from 6d86f29 to 93ffd72 Compare October 5, 2026 07:18
anandkaranubc pushed a commit that referenced this pull request Oct 5, 2026
@Planeshifter
fix: prevent non-terminating searches in `stats/base/dists/negative-b…
6dabe1c 
…inomial/quantile`

PR-URL: #14733
Reviewed-by: Athan Reines <kgryte@gmail.com>
Ref: stdlib-js/metr-issue-tracker#1227
Ref: #14730
@anandkaranubc
anandkaranubc force-pushed the philipp/negative-binomial-quantile-c branch from 93ffd72 to 6dabe1c Compare October 5, 2026 07:54
Base automatically changed from philipp/negative-binomial-cdf-c to develop October 5, 2026 20:54
@Planeshifter
feat: add C implementation for `stats/base/dists/negative-binomial/qu…
305cd8c 
…antile`

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter
fix: prevent non-terminating searches in `stats/base/dists/negative-b…
d4aa2ed 
…inomial/quantile`

PR-URL: #14733
Reviewed-by: Athan Reines <kgryte@gmail.com>
Ref: stdlib-js/metr-issue-tracker#1227
Ref: #14730
@Planeshifter
Planeshifter force-pushed the philipp/negative-binomial-quantile-c branch from 6dabe1c to d4aa2ed Compare October 5, 2026 21:46
@anandkaranubc
style: align with conventions of recently added C implementations
3c89555 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
docs: document p equal to zero behavior and fix parameter descriptions
9cc8fbf 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
test: add tests for non-advancing left searches
2ae773c 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
chore: update package keywords and R benchmark package name
60317b0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc anandkaranubc added C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. labels Oct 5, 2026
anandkaranubc
anandkaranubc approved these changes Oct 6, 2026
View reviewed changes

@anandkaranubc anandkaranubc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, @Planeshifter

@Planeshifter
Planeshifter merged commit 5fc7eb7 into develop Oct 6, 2026
48 checks passed
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandkaranubc anandkaranubc anandkaranubc approved these changes

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Good First PR A pull request resolving a Good First Issue. METR Pull request associated with the METR project. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/negative-binomial/quantile

3 participants

@Planeshifter @stdlib-bot @anandkaranubc