Repository navigation
fix: add support for wrapped line syntax highlighting and terminal resizing in the REPL output stream - #14701
Conversation
…esizing in the REPL output stream
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
REPL output streamREPL output stream
| * @memberof OutputStream.prototype | ||
| * @type {(integer|void)} | ||
| */ | ||
| setNonEnumerableReadOnlyAccessor( OutputStream.prototype, 'columns', function columns() { |
There was a problem hiding this comment.
If you are making this a public API, it needs to come after the _ prefixed methods/properties below.
There was a problem hiding this comment.
Why is this property necessary? As best I can tell, you never use it anywhere.
There was a problem hiding this comment.
Okay. I think I know what is going on. You need to override this property, I am guessing, as other consumers may assume the existence of a columns property?
There was a problem hiding this comment.
Yes, that's exactly it. The "other consumer" is Node's readline interface, which assumes its output stream exposes columns. Since OutputStream sits in front of the TTY, it must define columns to forward the viewport width; that's also why it has to keep the exact name columns rather than a _‑prefixed one.
|
Based on CI, looks like you've broken syntax highlighting. |
…ting test to account for cursor repositioning
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
left a comment
There was a problem hiding this comment.
I don't see anything off, but hard to say without actually using the REPL. So, let's go ahead and merge, and we can address any further issues in follow-up PRs.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #14646
Description
This pull request:
REPLoutput streamRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers