Repository navigation
feat: add C implementation for stats/base/dists/f/cdf - #14692
Merged
Merged
Conversation
Planeshifter
force-pushed
the
philipp/f-cdf-c
branch
from
August 27, 2026 05:52
a05bd55 to
9c5a833
Compare
Planeshifter
force-pushed
the
philipp/f-cdf-c
branch
2 times, most recently
from
August 27, 2026 06:04
2d6b3fa to
cb4038a
Compare
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_kebab_filenames
status: passed
---
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Planeshifter
force-pushed
the
philipp/f-cdf-c
branch
from
August 27, 2026 06:07
cb4038a to
8018118
Compare
Planeshifter
marked this pull request as ready for review
August 31, 2026 19:19
5 of 7 tasks
4 of 7 tasks
anandkaranubc
approved these changes
Oct 6, 2026
anandkaranubc
left a comment
Contributor
There was a problem hiding this comment.
Ready to merge, @Planeshifter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3594.
Description
This pull request:
@stdlib/stats/base/dists/f/cdf, including C headers, GYP/Makefile build configurations, JavaScript/C benchmarks and examples, native unit tests, and README documentation updates. The implementation is a faithful port of the JavaScript implementation, preserving parameter validation, endpoint behavior, NaN/infinity handling, and the incomplete-beta branch selection and complement handling used for numerical stability.Related Issues
This pull request has the following related issues:
Questions
No.
Other
isAlmostSameValuewith measured minimum ULP bounds (per RFC [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352 practice).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, using the merged
stats/base/dists/beta/cdfandbeta/logcdfC implementations as templates; the changes were validated locally (native addon built, all native tests passing, ULP bounds measured) before submission.@stdlib-js/reviewers