Skip to content

feat: add C implementation for stats/base/dists/betaprime/logcdf - #14676

Merged
Planeshifter merged 4 commits into
developfrom
philipp/betaprime-logcdf-c
Oct 8, 2026
Merged

feat: add C implementation for stats/base/dists/betaprime/logcdf#14676
Planeshifter merged 4 commits into
developfrom
philipp/betaprime-logcdf-c

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Resolves #3439.

Description

What is the purpose of this pull request?

This pull request:

  • adds a C implementation and Node-API native addon for @stdlib/stats/base/dists/betaprime/logcdf, including C headers, GYP/Makefile build configurations, JavaScript/C benchmarks and examples, native unit tests, and README documentation updates. The implementation applies the transformation x/(1+x) before delegating to @stdlib/stats/base/dists/beta/logcdf, mirroring the JavaScript implementation.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written primarily by Claude Code, using the stats/base/dists/betaprime/cdf and betaprime/pdf C implementations as templates; the changes were reviewed and validated locally (native addon built against the #13649 branch, all native tests passing) before submission.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Aug 27, 2026
@Planeshifter Planeshifter changed the title philipp/betaprime logcdf c feat: add C implementation for stats/base/dists/betaprime/logcdf Aug 27, 2026
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Aug 27, 2026
@Planeshifter
Planeshifter force-pushed the philipp/betaprime-logcdf-c branch from ce93891 to 2715126 Compare August 27, 2026 03:30
@Planeshifter Planeshifter added the METR Pull request associated with the METR project. label Aug 27, 2026
@stdlib-bot

stdlib-bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/betaprime/logcdf $\\color{green}335/335$
$\\color{green}+0.00\\%$ 		$\\color{green}29/29$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}335/335$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-js stdlib-js deleted a comment from stdlib-bot Aug 27, 2026
@Planeshifter
Planeshifter marked this pull request as ready for review August 27, 2026 05:15
@Planeshifter
Planeshifter requested a review from a team August 27, 2026 05:15
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 27, 2026
@anandkaranubc anandkaranubc mentioned this pull request Oct 2, 2026
Open
@anandkaranubc
anandkaranubc force-pushed the philipp/betaprime-logcdf-c branch from 2715126 to 7ceaba5 Compare October 6, 2026 01:57
Base automatically changed from philipp/betaprime-cdf-c to develop October 6, 2026 15:36
@Planeshifter @claude @anandkaranubc
feat: add C implementation for stats/base/dists/betaprime/logcdf
e62bf9a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_kebab_filenames
    status: passed
---

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@anandkaranubc
anandkaranubc force-pushed the philipp/betaprime-logcdf-c branch from 7ceaba5 to e62bf9a Compare October 6, 2026 16:45
@anandkaranubc
docs: update C comments and examples to match conventions
cf9457e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
style: sort variable declarations to match conventions
b725b48 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
test: use measured ULP tolerances and align test conventions
a13b3f3 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc anandkaranubc added C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. labels Oct 6, 2026
anandkaranubc
anandkaranubc approved these changes Oct 6, 2026
View reviewed changes

@anandkaranubc anandkaranubc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, @Planeshifter

@Planeshifter
Planeshifter merged commit c36cc64 into develop Oct 8, 2026
48 checks passed
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandkaranubc anandkaranubc anandkaranubc approved these changes

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Good First PR A pull request resolving a Good First Issue. METR Pull request associated with the METR project. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/betaprime/logcdf

3 participants

@Planeshifter @stdlib-bot @anandkaranubc