Skip to content

feat: add C implementation for stats/base/dists/chisquare/quantile - #14658

Merged
Planeshifter merged 5 commits into
developfrom
philipp/chisquare-quantile-c
Oct 5, 2026
Merged

feat: add C implementation for stats/base/dists/chisquare/quantile#14658
Planeshifter merged 5 commits into
developfrom
philipp/chisquare-quantile-c

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • adds a C native addon implementation for stats/base/dists/chisquare/quantile

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Thin wrapper that delegates to stdlib_base_dists_gamma_quantile(p, k/2.0, 0.5).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code under my direction.

@stdlib-js/reviewers

@Planeshifter
Planeshifter force-pushed the philipp/chisquare-quantile-c branch from f16dc46 to 7538e93 Compare August 26, 2026 16:55
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Aug 26, 2026
@Planeshifter
Planeshifter force-pushed the philipp/chisquare-quantile-c branch from 7538e93 to fdce5eb Compare August 26, 2026 17:18
@Planeshifter
Planeshifter marked this pull request as ready for review August 26, 2026 17:20
@Planeshifter
Planeshifter requested a review from a team August 26, 2026 17:20
@Planeshifter
Planeshifter force-pushed the philipp/chisquare-quantile-c branch from fdce5eb to fd8a329 Compare August 26, 2026 17:29
@Planeshifter
Planeshifter changed the base branch from develop to philipp/gamma-quantile-c August 26, 2026 17:29
@Planeshifter
Planeshifter force-pushed the philipp/chisquare-quantile-c branch 2 times, most recently from b9dbfc7 to 3a34ee2 Compare August 26, 2026 17:36
@stdlib-bot

stdlib-bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/chisquare/quantile $\\color{green}256/256$
$\\color{green}+0.00\\%$ 		$\\color{green}7/7$
$\\color{green}+0.00\\%$ 		$\\color{green}3/3$
$\\color{green}+0.00\\%$ 		$\\color{green}256/256$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 26, 2026
@anandkaranubc anandkaranubc mentioned this pull request Oct 2, 2026
Open
@anandkaranubc
anandkaranubc force-pushed the philipp/chisquare-quantile-c branch 2 times, most recently from c32c456 to 4853d6f Compare October 4, 2026 21:42
@anandkaranubc
anandkaranubc self-requested a review October 5, 2026 04:07
@anandkaranubc anandkaranubc added C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. labels Oct 5, 2026
anandkaranubc
anandkaranubc previously approved these changes Oct 5, 2026
View reviewed changes

@anandkaranubc anandkaranubc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, @Planeshifter

@Planeshifter
Planeshifter force-pushed the philipp/chisquare-quantile-c branch from 02b40d7 to 54c2bea Compare October 5, 2026 04:56
@Planeshifter
Planeshifter removed this pull request from stack #14667 October 5, 2026 04:58
@Planeshifter
Planeshifter changed the base branch from philipp/gamma-quantile-c to develop October 5, 2026 04:58
@Planeshifter
Planeshifter added this pull request to stack #15902 October 5, 2026 04:58
Planeshifter and others added 5 commits October 4, 2026 22:21
@Planeshifter @claude
feat: add C implementation for stats/base/dists/chisquare/quantile
fa0b67c 
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@anandkaranubc
docs: update documentation and examples
d262860 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
test: update tolerances and assertion messages
d421d6d 
The exact minimum ULP tolerance over the fixture set is 402 for the JavaScript, native, and factory code paths alike.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
chore: code review
e6a73d8 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
chore: update keywords
14f51e4 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
anandkaranubc force-pushed the philipp/chisquare-quantile-c branch from 54c2bea to 14f51e4 Compare October 5, 2026 05:21
@Planeshifter
Planeshifter merged commit cd8a679 into develop Oct 5, 2026
16 checks passed
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 5, 2026
@Planeshifter
Planeshifter deleted the philipp/chisquare-quantile-c branch October 5, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandkaranubc anandkaranubc anandkaranubc left review comments

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Planeshifter @stdlib-bot @anandkaranubc