Repository navigation
test: migrate stats/base/dists/uniform/quantile to ULP-based assertions - #14626
Merged
Merged
Conversation
…ions Replace relative tolerance assertions with `isAlmostSameValue` ULP difference assertions in the `stats/base/dists/uniform/quantile` test suite. All fixture values match exactly, so the minimum required ULP bound is `0` for the JavaScript, factory, and native test files. Ref: #11352 Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NbeWLyp2YBanmPrDdD2hsX --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/uniform/quantilefrom relative tolerance (EPS/delta/tol) assertions to ULP difference assertions using@stdlib/assert/is-almost-same-value.test/test.quantile.js,test/test.factory.js, andtest/test.native.js. No other files are changed.The ULP bound was tightened agentically: starting from a high bound and lowering to the minimum integer which still passes over the full fixture set (
small_range,medium_range,large_range; 1000 cases each, 3000 total per file).Measured minimum ULP bound:
test/test.quantile.jssmall_range,medium_range,large_range0test/test.factory.jssmall_range,medium_range,large_range0test/test.native.jssmall_range,medium_range,large_range0Both the JavaScript and C implementations compute
a + ( p * ( b - a ) ), and every fixture value matches bit-for-bit, so0is the tightest possible bound in all three files.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
test/test.js,test/test.quantile.js(3011 assertions),test/test.factory.js(3014 assertions), andtest/test.native.js(3011 assertions) all pass. The native add-on was built locally (make install-node-addons NODE_ADDONS_PATTERN="stats/base/dists/uniform/quantile") so thattest/test.native.jswas actually exercised rather than skipped.0to confirm determinism (no FMA/architecture-dependent variation).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated, mechanical migration of existing test assertions to ULP-based assertions, following the idiom established in previously merged PRs referencing #11352. The ULP bound was determined empirically by running the fixtures and minimizing the accepted bound.
@stdlib-js/reviewers
Generated by Claude Code