Skip to content

feat: add float16 dtype support to array/from-scalar - #14621

Merged
kgryte merged 3 commits into
stdlib-js:developfrom
Erennn7:float16-support/array/from-scalar
Aug 30, 2026
Merged

kgryte merged 3 commits into
stdlib-js:developfrom
Erennn7:float16-support/array/from-scalar

Conversation

@Erennn7

@Erennn7 Erennn7 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Progresses #13193

Description

What is the purpose of this pull request?

This pull request:

  • add float16 dtype support to array/from-scalar

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@Erennn7
Erennn7 requested a review from a team August 25, 2026 14:48
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 25, 2026
@stdlib-bot

stdlib-bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/from-scalar $\\color{green}158/158$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}158/158$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title feat: add float16 dtype support to array/from-scalar feat: add float16 dtype support to array/from-scalar Aug 26, 2026
@kgryte
kgryte requested a review from gururaj1512 August 26, 2026 00:58
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Aug 26, 2026
Comment thread lib/node_modules/@stdlib/array/from-scalar/package.json Outdated
Comment thread lib/node_modules/@stdlib/array/from-scalar/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/array/from-scalar/test/test.js Outdated
@kgryte

kgryte commented Aug 28, 2026

Copy link
Copy Markdown
Member

@Erennn7 Now that isSameFloat16Array has been added, you can go ahead and update this PR. Cheers!

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Aug 28, 2026
@Erennn7
Erennn7 force-pushed the float16-support/array/from-scalar branch from 2641189 to 6cf0b23 Compare August 29, 2026 20:19
@Erennn7
Erennn7 marked this pull request as draft August 29, 2026 20:20
@Erennn7
Erennn7 marked this pull request as ready for review August 29, 2026 20:33
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 29, 2026

@gururaj1512 gururaj1512 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Aug 30, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
kgryte merged commit acbf27e into stdlib-js:develop Aug 30, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants