Repository navigation
test: migrate math/base/tools/hermitepoly to ULP-based assertions - #14613
Merged
Merged
Conversation
Resolves a part of #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage ReportNo coverage information available. |
kgryte
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/tools/hermitepolytest files (test/test.jsandtest/test.factory.js) from relative-tolerance (EPS-baseddelta/tol) assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value.H_n(x)for randomnandx:2H_1(x):0(small positive/negative, tiny, medium positive/negative)H_2(x):0(small positive/negative, tiny, medium positive/negative)H_5(x):2(small positive/negative, tiny, medium positive/negative)Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No extraneous changes were made; only the tolerance-based assertions in
test/test.jsandtest/test.factory.jswere migrated. No other files were changed.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which studied issue #11352 and prior merged/open ULP-migration PRs (including the sibling
math/base/tools/normhermitepolyconversion) to mirror the established idiom, then computed the minimum passing ULP bound per test block by directly measuring ULP differences between computed and expected values.@stdlib-js/reviewers
Generated by Claude Code