Repository navigation
test: migrate stats/base/dists/beta/skewness to ULP-based assertions - #14606
Merged
Merged
Conversation
Migrate the relative tolerance assertions in the fixture loops to `isAlmostSameValue` ULP difference assertions. Over the full Julia fixture set (1000 cases), the returned values match the expected values exactly, so the minimum required ULP bound is `0`. Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/beta/skewnessfrom relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.Specifically, in both
test/test.jsandtest/test.native.js, the exact-match/relative-tolerance branch in the fixture loopis replaced by
along with adding the
@stdlib/assert/is-almost-same-valuerequire and removing the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires and thedelta/toldeclarations.ULP bound
0(used in bothtest/test.jsandtest/test.native.js).0. Starting from a bound of64, the bound was lowered while the suite continued to pass. Over the full Julia fixture set (1000 cases intest/fixtures/julia/data.json), the maximum ULP difference between the returned and expected values is0, i.e., every returned value is bit-identical to the expected value, so0is the tightest possible bound.This is consistent with the implementation: both the JavaScript and C implementations evaluate the same expression using only correctly rounded IEEE 754 operations (
+,-,*,/, andsqrt), with no FMA-contractiblea*b + cpattern, so the result is expected to be reproducible across platforms.Note that
test/test.native.jsis skipped in this environment because the native add-on is not built; the bound there matches the JavaScript bound, as in previously migrated packages.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only the two test files are modified; no source, documentation, benchmark, or fixture files are touched.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended task. It studied previously merged migrations (e.g.,
stats/base/dists/beta/entropy) to mirror the established idiom, applied the mechanical test refactor, and empirically determined the minimum ULP bound by running the package's test suite.@stdlib-js/reviewers
Generated by Claude Code