Repository navigation
test: migrate stats/base/dists/pareto-type1/mode to ULP-based assertions - #14600
Merged
Merged
Conversation
…tions Replace relative tolerance assertions with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The fixture values are reproduced exactly by both the JavaScript and native implementations, so the minimum required ULP bound is 0. Ref: #11352 Claude-Session: https://claude.ai/code/session_01R3iiGUHsbFsVTijqPUmedr --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/pareto-type1/modefrom relative tolerance testing to ULP difference testing.Specifically, in both
test/test.jsandtest/test.native.js, thedelta/tolcomputation and thet.ok( delta <= tol, ... )assertion are replaced byalong with adding the
@stdlib/assert/is-almost-same-valuerequire and removing the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.Final ULP constant:
0(for bothtest/test.jsandtest/test.native.js).The bound was tightened empirically. Starting from a high value and lowering it, the measured maximum ULP difference across the full fixture set (1000 cases in
test/fixtures/julia/data.json) is0, i.e. both the JavaScript and native implementations reproduce the Julia reference values exactly, so0is the minimum required ULP value. The previous relative tolerance was1.0 * EPS.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed locally:
make test TESTS_FILTER=".*/stats/base/dists/pareto-type1/mode/.*"— 1014 passing / 0 failing fortest/test.jsand 1014 passing / 0 failing fortest/test.native.js(the native add-on was built locally so thattest/test.native.jsactually ran rather than being skipped).make lint-javascript-tests TESTS_FILTER=".*/stats/base/dists/pareto-type1/mode/.*"— clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, running unattended as a scheduled task. It studied the conventions established by previously merged conversions in this family (e.g.
stats/base/dists/pareto-type1/kurtosis,stats/base/dists/beta/entropy), applied the same idiom, and determined the minimum ULP bound by measurement against the fixture set. Opened as a draft for human review.@stdlib-js/reviewers
Generated by Claude Code