Skip to content

test: migrate stats/base/dists/pareto-type1/mode to ULP-based assertions - #14600

Merged
kgryte merged 1 commit into
developfrom
kgryte/ulp-stats-base-dists-pareto-type1-mode
Aug 25, 2026
Merged

kgryte merged 1 commit into
developfrom
kgryte/ulp-stats-base-dists-pareto-type1-mode

Conversation

@kgryte

@kgryte kgryte commented Aug 24, 2026

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates the tests for stats/base/dists/pareto-type1/mode from relative tolerance testing to ULP difference testing.

Specifically, in both test/test.js and test/test.native.js, the delta/tol computation and the t.ok( delta <= tol, ... ) assertion are replaced by

t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );

along with adding the @stdlib/assert/is-almost-same-value require and removing the now unused @stdlib/math/base/special/abs and @stdlib/constants/float64/eps requires.

Final ULP constant: 0 (for both test/test.js and test/test.native.js).

The bound was tightened empirically. Starting from a high value and lowering it, the measured maximum ULP difference across the full fixture set (1000 cases in test/fixtures/julia/data.json) is 0, i.e. both the JavaScript and native implementations reproduce the Julia reference values exactly, so 0 is the minimum required ULP value. The previous relative tolerance was 1.0 * EPS.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Verification performed locally:

  • make test TESTS_FILTER=".*/stats/base/dists/pareto-type1/mode/.*" — 1014 passing / 0 failing for test/test.js and 1014 passing / 0 failing for test/test.native.js (the native add-on was built locally so that test/test.native.js actually ran rather than being skipped).
  • The suite was run twice at the final ULP value to confirm the result is deterministic.
  • make lint-javascript-tests TESTS_FILTER=".*/stats/base/dists/pareto-type1/mode/.*" — clean.
  • Only the two test files are changed; no source, documentation, or fixture files were touched.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code, running unattended as a scheduled task. It studied the conventions established by previously merged conversions in this family (e.g. stats/base/dists/pareto-type1/kurtosis, stats/base/dists/beta/entropy), applied the same idiom, and determined the minimum ULP bound by measurement against the fixture set. Opened as a draft for human review.


@stdlib-js/reviewers


Generated by Claude Code

…tions

Replace relative tolerance assertions with ULP difference assertions
using `@stdlib/assert/is-almost-same-value`. The fixture values are
reproduced exactly by both the JavaScript and native implementations,
so the minimum required ULP bound is 0.

Ref: #11352

Claude-Session: https://claude.ai/code/session_01R3iiGUHsbFsVTijqPUmedr

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Aug 24, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/pareto-type1/mode $\\color{green}195/195$
$\\color{green}+100.00\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}195/195$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Aug 24, 2026
@kgryte
kgryte marked this pull request as ready for review August 24, 2026 23:59
@kgryte
kgryte requested a review from a team August 24, 2026 23:59
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 24, 2026
@kgryte
kgryte merged commit fae5d5a into develop Aug 25, 2026
82 checks passed
@kgryte
kgryte deleted the kgryte/ulp-stats-base-dists-pareto-type1-mode branch August 25, 2026 00:00
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants