Repository navigation
test: migrate math/base/special/cfloorn to ULP-based assertions - #14542
Merged
Merged
Conversation
Resolves a part of #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/cfloorntest cases from relative-tolerance (EPS-based) comparisons to ULP-difference-based assertions, per the RFC in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.jsandtest/test.native.js, the single test case using the olddelta = abs( ... ); tol = EPS * abs( ... ); t.strictEqual( delta <= tol, true, ... )idiom (subnormal-rounding test) is replaced witht.strictEqual( isAlmostSameValue( ..., ..., 1 ), true, 'returns expected value' ), dropping the now-unusedEPSandabsrequires in favor of@stdlib/assert/is-almost-same-value.1passes the full fixture set (890 assertions intest.js);0(exact equality) fails 12 of those assertions, so1is the minimum required bound.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
test/test.native.jsmirrors the same conversion for the native addon test file; those tests are skipped in this environment (no compiled native addon available), buttest/test.jswas run twice to confirm deterministic results at ULP=1.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, mirroring the ULP-migration idiom from prior merged PRs in the same package family (e.g.
math/base/special/cceiln,math/base/special/floorn) and empirically tightening the ULP bound as described above.@stdlib-js/reviewers
Generated by Claude Code