Repository navigation
test: migrate math/base/special/sincosdf to ULP-based assertions - #14521
Merged
Merged
Conversation
Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Math
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/sincosdffrom relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomparisons (and theirif ( y === expected ) { ... } else { ... }wrappers) withisAlmostSameValue( actual, expected, N )assertions, using@stdlib/number/float32/base/assert/is-almost-same-value, as the package operates on single-precision values.@stdlib/constants/float32/epsand@stdlib/math/base/special/absfimports, along with thedeltaandtollocal variables.test/test.main.js,test/test.assign.js, andtest/test.native.js.test/test.jsis a smoke test which contains no tolerance-based assertions and is thus left unchanged.The ULP bounds were measured against the full fixture set (6 fixture files x 4000 values, for both the sine and cosine outputs) and set to the minimum value which passes:
sinecosinemedium_negativemedium_positivelarge_negativelarge_positivehuge_negativehuge_positiveEach bound is tight. For every bound of
1, at least one fixture value differs from the expected value by exactly 1 ULP (e.g., 645 of 4000 sine values inmedium_negative), so0fails. For every bound of0, all 4000 values match exactly.The measured maxima are identical for the JavaScript implementation (
lib/main.js), theassignimplementation (lib/assign.js), and the C implementation (lib/native.js), so the same bounds are used in all three test files. The native addon was compiled locally in order to confirm this.The full package test suite (
make test TESTS_FILTER=".*/math/base/special/sincosdf/.*") was run twice at the final bounds, with identical results both times (48008 / 72024 / 6 / 48008 assertions passing, 0 failing).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only test files are changed; no source, documentation, or fixture files are modified.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. The test edits were applied mechanically, the ULP bounds were derived from measured per-fixture ULP-difference histograms rather than guessed, and the prior art in already-migrated packages (e.g.,
math/base/special/sici,math/base/special/logitf) was used to match the established idiom. Opened as a draft for human review.@stdlib-js/reviewers
Generated by Claude Code