[gunjjoshi]

---

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

• task: lint_filenames status: passed
• task: lint_editorconfig status: passed
• task: lint_markdown_pkg_readmes status: passed
• task: lint_markdown_docs status: na
• task: lint_markdown status: na
• task: lint_package_json status: passed
• task: lint_repl_help status: passed
• task: lint_javascript_src status: passed
• task: lint_javascript_cli status: na
• task: lint_javascript_examples status: passed
• task: lint_javascript_tests status: passed
• task: lint_javascript_benchmarks status: passed
• task: lint_python status: na
• task: lint_r status: na
• task: lint_c_src status: na
• task: lint_c_examples status: na
• task: lint_c_benchmarks status: na
• task: lint_c_tests_fixtures status: na
• task: lint_shell status: na
• task: lint_typescript_declarations status: passed
• task: lint_typescript_tests status: passed
• task: lint_license_headers status: passed ---

Resolves stdlib-js/metr-issue-tracker#1209.

Description

What is the purpose of this pull request?

This pull request:

• adds fft/base/fftpack/float32/decompose, which will be the float32 equivalent for fft/base/fftpack/generic/decompose.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

• [RFC]: add fft/base/fftpack/float32/decompose metr-issue-tracker#1209.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

• Yes
• No

If you answered "yes" above, how did you use AI assistance?

• Code generation (e.g., when writing an implementation or fixing a bug)
• Test/benchmark generation
• Documentation (including examples)
• Research and understanding
• Code review

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used Claude Code to review the implementation that I did manually.

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
fft/base/fftpack/float32/decompose	$\\color{green}257/257$ $\\color{green}+0.00\\%$	$\\color{green}17/17$ $\\color{green}+0.00\\%$	$\\color{green}1/1$ $\\color{green}+0.00\\%$	$\\color{green}257/257$ $\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

[kgryte]

@gunjjoshi Are you wanting to perform float32 emulation? Given your use of floorf above, I am guessing you are. In which case, you need to use f32(...) around each applicable arithmetic operation.

[kgryte]

I believe this only applies to operations involving nq, nl, and nr.

[gunjjoshi]

Yes, right. I had missed it. Added it in ba20bc8. I have applied it to nq and nr. nl didn't seem to be involved in any arithmetic operartion directly.

[kgryte]

Other than the question of float32 emulation, this PR is looking good.

[gunjjoshi]

Thanks @kgryte, I have updated the PR now to use float32 emulation.

[kgryte]

LGTM