[Arjan-P]

---

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

• task: lint_filenames status: passed
• task: lint_editorconfig status: passed
• task: lint_markdown_pkg_readmes status: na
• task: lint_markdown_docs status: na
• task: lint_markdown status: na
• task: lint_package_json status: passed
• task: lint_repl_help status: na
• task: lint_javascript_src status: passed
• task: lint_javascript_cli status: na
• task: lint_javascript_examples status: na
• task: lint_javascript_tests status: na
• task: lint_javascript_benchmarks status: na
• task: lint_python status: na
• task: lint_r status: na
• task: lint_c_src status: missing_dependencies
• task: lint_c_examples status: na
• task: lint_c_benchmarks status: na
• task: lint_c_tests_fixtures status: na
• task: lint_shell status: na
• task: lint_typescript_declarations status: passed
• task: lint_typescript_tests status: na
• task: lint_license_headers status: passed ---

Resolves part of #14819.

Description

What is the purpose of this pull request?

This pull request:

• Add C implementation for blas/ext/base/ndarray/dtril

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

• [RFC]: add C implementations for blas/ext/base/ndarray packages #14819

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

• Yes
• No

If you answered "yes" above, how did you use AI assistance?

• Code generation (e.g., when writing an implementation or fixing a bug)
• Test/benchmark generation
• Documentation (including examples)
• Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

---

@stdlib-js/reviewers

[Arjan-P]

Hi @kgryte, had a question regarding this. The package here has scalars begin created as:

 var k = scalar2ndarray( 0, {
     'dtype': 'generic'
 });

But since @stdlib/ndarray/base/buffer create those using @stdlib/array/base/zeros, it's not backed by ArrayBuffer's, So it can't be passed down to stdlib_ndarray_napi_addon_arguments. Would it be appropriate to update those to have dtype: int32, since even the underlying stdlib_strided_dtril_ndarray expects that of k?

[kgryte]

Yes, update to int32.

[kgryte]

You can update them throughout the package to use int32 rather than generic.

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/ndarray/dtril	$\\color{green}226/226$ $\\color{green}+100.00\\%$	$\\color{green}7/7$ $\\color{green}+100.00\\%$	$\\color{green}2/2$ $\\color{green}+100.00\\%$	$\\color{green}226/226$ $\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

[AryanSharma48]

Hey @Arjan-P, while working on adding the native C implementation for its single-precision sister package, blas/ext/base/ndarray/stril, I was reviewing how you implemented this PR. I noticed a few minor typos and leftover artifacts:

• src/main.c (line 24): #include <stdio.h> is likely unused since no I/O operations are called in this file.
• test/test.js: It looks like this file was copied from dsum—dsum is used as the variable name across the entire file (lines 28, 41, 46, 50, 60, 65, 69) instead of dtril. A quick global replace of dsum to dtril will clean that right up.
• README.md (line 231): Typo in the C example strides definition: (int64_6) instead of (int64_t).
• benchmark/c/benchmark.length.c (line 123): k_data is declared as CBLAS_INT k_data[ 1 ], but allocated with STDLIB_NDARRAY_INT32 (and example.c uses int32_t k_data[]). For consistency and type safety across 64-bit BLAS builds, int32_t k_data[ 1 ] would be better.
• benchmark/c/benchmark.length.c (lines 156 & 178–180):
  • Line 156: Missing space before the closing parenthesis (submodes); to submodes );), and missing // cppcheck-suppress invalidPointerCast above k's allocation.
  • Lines 178–179: In the cleanup section, arrays[ 2 ] = NULL; is missing after setting arrays[ 0 ] and arrays[ 1 ] to NULL.

Just some minor things i found, hope this helps polish it up for merge!

[Arjan-P]

@AryanSharma48 Thanks for the help catching these. Will fix these up ASAP.