Repository navigation
test: migrate math/base/special/fast/atanh to ULP-based assertions - #14457
Merged
Merged
Conversation
Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CtsVG1PwNF7Rdg1zo4amRT
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 21, 2026 05:50
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/fast/atanhfrom relative tolerance testing (delta <= EPS * abs( expected )) to ULP difference testing using@stdlib/assert/is-almost-same-value.Changes are confined to
test/test.jsandtest/test.native.js. No source, documentation, benchmark, or fixture files were touched, and no test cases were added, removed, or reordered.The measured minimum ULP bounds (the maximum observed ULP difference across the full fixture set, i.e. the smallest integer for which every case passes) are:
fixtures/julia/negative.json)500.0 * EPS * abs( expected )468fixtures/julia/positive.json)650.0 * EPS * abs( expected )655Each bound was tightened to the minimum:
468and655pass for every fixture value, while467and654do not.The same bounds apply to both
test.jsandtest.native.js. The native add-on was built locally, and the C implementation was verified to produce bit-identical results to the JavaScript implementation across both fixture files (max ULP difference of468and655, respectively), so no JS/C divergence adjustment was required.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed:
make test TESTS_FILTER=".*/math/base/special/fast/atanh/.*"— 6015 passing / 0 failing intest.jsand 6015 passing / 0 failing intest.native.js. The suite was run twice at the final ULP values with identical results (no FMA/architecture-dependent variation observed).etc/eslint/.eslintrc.tests.js— clean for both changed files.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. It studied the migration guidance in #11352 and the already-migrated sibling packages (
math/base/special/fast/asinh,math/base/special/fast/acosh) to mirror the established idiom, measured the ULP bounds empirically against the fixtures, and ran the test suite and linter locally.@stdlib-js/reviewers
Generated by Claude Code