Repository navigation
test: migrate math/base/special/logitf to ULP-based assertions - #14456
Merged
Merged
Conversation
Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/logitffrom relative-tolerance assertions (delta = absf( y - expected[i] ),tol = EPS * absf( expected[i] ),t.ok( delta <= tol, ... )) to ULP-difference assertions using@stdlib/number/float32/base/assert/is-almost-same-value.test/test.jsandtest/test.native.js.NaN, values outside[0,1],0, and1).Expected values are converted to single-precision via
@stdlib/number/float64/base/to-float32before comparison, consistent with other migrated single-precision packages (e.g.,math/base/special/xlogyf,math/base/special/log10f,math/base/special/rad2degf).The minimum ULP bounds used per fixture block (identical for
test.jsandtest.native.js) are:small((0,0.25])medium([0.25,0.75])large([0.75,1))Each ULP value is the minimum integer
Nsuch thatisAlmostSameValuef( actual, expected, N )holds for every fixture entry in that block; the measured maximum ULP difference is1for all three blocks (500 fixture values each), andN = 0fails (113 cases). The JavaScript and C implementations produce identical results across the full fixture set, so both test files use the same bounds. Tests were run twice at the finalN(1507 assertions passing per file, native addon built locally sotest.native.jswas exercised rather than skipped) to confirm deterministic passing.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code: the assistant mechanically converted the tolerance-based assertions to
isAlmostSameValuef, agentically searched for the minimum ULP bound per fixture block, verified determinism across two full runs, and ran the local lint and test suites before submitting.@stdlib-js/reviewers
Generated by Claude Code