Repository navigation
test: migrate stats/base/dists/chi/stdev to ULP-based assertions - #14447
Merged
Merged
Conversation
Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 21, 2026 00:02
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
@stdlib/stats/base/dists/chi/stdevfrom relative-tolerance assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value, per the guidance in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.jsandtest/test.native.jsto mirror the idiom used in previously converted packages (e.g.stats/base/dists/erlang/stdev,stats/base/dists/frechet/variance).50.0 * EPS * abs( expected[ i ] )tolerance loop witht.strictEqual( isAlmostSameValue( y, expected[ i ], 64 ), true, 'returns expected value' ).@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.The tightest ULP bound was determined empirically by measuring the maximum ULP difference over the full 1000-value Python fixture set:
test/test.js: N = 64 ULP (max observed ULP difference over the fixtures is exactly 64; the worst case isk = 7.448033732206665, wherestdev(k)differs from the expected value by 64 ULP).test/test.native.js: N = 64 ULP (same fixtures; native tests are skipped in this environment because the native add-on is not built, so the same bound is used for consistency with the JavaScript implementation).The tests were run twice at the final
N = 64(1005 assertions, all passing) to confirm the bound is deterministic.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code (Anthropic) running as an unattended scheduled task. The conversion mirrors the exact idiom used in previously merged ULP migrations authored by the PR author (e.g. #14439, #14434), and the ULP bound was measured empirically against the existing Python fixtures.
@stdlib-js/reviewers
Generated by Claude Code