Repository navigation
chore: clean-up - #14443
Merged
Merged
chore: clean-up#14443
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TxJcoaUHMinds5gCP7dY94
…ftpack/ndarray/generic` Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TxJcoaUHMinds5gCP7dY94
…se/fftpack` Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TxJcoaUHMinds5gCP7dY94
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 21, 2026 00:24
kgryte
approved these changes
Aug 21, 2026
fft/base/fftpack namespaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-08-19 11:15 PDT (542efe8) and 2026-08-20 03:56 PDT (fd3c50f). An automated review of the window's 56 commits surfaced ten high-signal issues, all in the newfft/base/fftpacknamespace packages.This pull request:
fft/base/fftpack/ndarraynamefield inlib/node_modules/@stdlib/fft/base/fftpack/ndarray/package.jsonfrom 1fadbac — it was copy-pasted from the parent package, colliding with@stdlib/fft/base/fftpack; now set to@stdlib/fft/base/fftpack/ndarray.lib/node_modules/@stdlib/fft/base/fftpack/ndarray/lib/index.js:@name basenow reads@name genericto match thesetReadOnlyproperty, mirroring the fix already applied to the parent namespace in fd3c50f.fft/base/fftpack/ndarray/docs/types/index.d.tsdescribed the interface as thefftpacknamespace instead ofndarray. Corrected to match the file it actually documents.genericmember infft/base/fftpack/ndarray'sdocs/types/index.d.ts, shipped in 1fadbac — now reads "Lower-level ndarray wrappers for generic FFTPACK fast Fourier transform routines." to match the package description.fft/base/fftpack/ndarray/genericns.rfftitype signature: c6ce075 imported the strided kernel@stdlib/fft/base/fftpack/generic/rfftiinlib/node_modules/@stdlib/fft/base/fftpack/ndarray/generic/docs/types/index.d.tsinstead of the ndarray wrapper, so the declared signature didn't match what the namespace actually exports. Swapped the import to@stdlib/fft/base/fftpack/ndarray/generic/rffti.rffti's placeholder "TODO." JSDoc inlib/node_modules/@stdlib/fft/base/fftpack/ndarray/generic/docs/types/index.d.ts(c6ce075), pulling full docs from the member's own declaration file and aligning the example withns.rfftiper thefftpack/genericnamespace convention.fft/base/fftpackfftpacknamespace ToC label:generic, notbase—lib/node_modules/@stdlib/fft/base/fftpack/README.mdlinks to.../fftpack/genericbut was headedbase, a leftover from the earlier@name baseannotation (README regenerated in f66e808; the annotation was fixed in fd3c50f without regenerating the README).ndarray, missed in fd3c50f (lib/index.jsadded the entry, butlib/node_modules/@stdlib/fft/base/fftpack/README.mdnever got the ToC row or the[@stdlib/fft/base/fftpack/ndarray]link definition). Added both.ns.ndarraytype error introduced in fd3c50f:lib/node_modules/@stdlib/fft/base/fftpack/docs/types/index.d.tswas never updated to declare thendarraymember, so TS consumers couldn't access it despite it existing at runtime. Adds thendarrayimport andNamespacemember.genericdescription infft/base/fftpack/docs/types/index.d.ts(92b8505) to read "on generic collections", matching the wording already applied to the siblingfft/base/fftpack/genericdeclaration in 3c3b738 — same phrase, just missed in this file.Related Issues
No.
Questions
No.
Other
Validation. The window's 56 commits were reviewed for (1) stdlib style-guide compliance (checked against
docs/style-guidesand established reference packages) and (2) objective bugs within the changed code (independent parallel scans, findings cross-verified against the files on disk). Only issues corroborated by multiple independent reviews or directly re-verifiable from the diff were kept. Deliberately excluded: subjective suggestions, anything requiring interpretation, and anything whose fix would require touching code outside the window's diff (e.g. the ULP test migrations, the Waldlogpdfrewrite, and the fftpack package relocations were all confirmed as intentional and left untouched).Note. This PR is intentionally a draft; a maintainer will audit and promote it.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code as part of an automated daily review of commits merged to
develop; all fixes were cross-verified by multiple independent review passes before being applied.Generated by Claude Code