Skip to content

chore: clean-up - #14443

Merged
kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-08-20
Aug 21, 2026
Merged

kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-08-20

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-08-19 11:15 PDT (542efe8) and 2026-08-20 03:56 PDT (fd3c50f). An automated review of the window's 56 commits surfaced ten high-signal issues, all in the new fft/base/fftpack namespace packages.

This pull request:

fft/base/fftpack/ndarray

  • Fixed the duplicate name field in lib/node_modules/@stdlib/fft/base/fftpack/ndarray/package.json from 1fadbac — it was copy-pasted from the parent package, colliding with @stdlib/fft/base/fftpack; now set to @stdlib/fft/base/fftpack/ndarray.
  • Fixes a leftover copy-paste error from 1fadbac in lib/node_modules/@stdlib/fft/base/fftpack/ndarray/lib/index.js: @name base now reads @name generic to match the setReadOnly property, mirroring the fix already applied to the parent namespace in fd3c50f.
  • Fixes a copy-paste doc-comment bug from 1fadbac: fft/base/fftpack/ndarray/docs/types/index.d.ts described the interface as the fftpack namespace instead of ndarray. Corrected to match the file it actually documents.
  • Fix the "TODO." placeholder JSDoc on the generic member in fft/base/fftpack/ndarray's docs/types/index.d.ts, shipped in 1fadbac — now reads "Lower-level ndarray wrappers for generic FFTPACK fast Fourier transform routines." to match the package description.

fft/base/fftpack/ndarray/generic

  • Fixed the ns.rffti type signature: c6ce075 imported the strided kernel @stdlib/fft/base/fftpack/generic/rffti in lib/node_modules/@stdlib/fft/base/fftpack/ndarray/generic/docs/types/index.d.ts instead of the ndarray wrapper, so the declared signature didn't match what the namespace actually exports. Swapped the import to @stdlib/fft/base/fftpack/ndarray/generic/rffti.
  • Fix rffti's placeholder "TODO." JSDoc in lib/node_modules/@stdlib/fft/base/fftpack/ndarray/generic/docs/types/index.d.ts (c6ce075), pulling full docs from the member's own declaration file and aligning the example with ns.rffti per the fftpack/generic namespace convention.

fft/base/fftpack

  • Fix the fftpack namespace ToC label: generic, not base — lib/node_modules/@stdlib/fft/base/fftpack/README.md links to .../fftpack/generic but was headed base, a leftover from the earlier @name base annotation (README regenerated in f66e808; the annotation was fixed in fd3c50f without regenerating the README).
  • Fixed the fftpack namespace README to include ndarray, missed in fd3c50f (lib/index.js added the entry, but lib/node_modules/@stdlib/fft/base/fftpack/README.md never got the ToC row or the [@stdlib/fft/base/fftpack/ndarray] link definition). Added both.
  • Fixes ns.ndarray type error introduced in fd3c50f: lib/node_modules/@stdlib/fft/base/fftpack/docs/types/index.d.ts was never updated to declare the ndarray member, so TS consumers couldn't access it despite it existing at runtime. Adds the ndarray import and Namespace member.
  • Fixed generic description in fft/base/fftpack/docs/types/index.d.ts (92b8505) to read "on generic collections", matching the wording already applied to the sibling fft/base/fftpack/generic declaration in 3c3b738 — same phrase, just missed in this file.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. The window's 56 commits were reviewed for (1) stdlib style-guide compliance (checked against docs/style-guides and established reference packages) and (2) objective bugs within the changed code (independent parallel scans, findings cross-verified against the files on disk). Only issues corroborated by multiple independent reviews or directly re-verifiable from the diff were kept. Deliberately excluded: subjective suggestions, anything requiring interpretation, and anything whose fix would require touching code outside the window's diff (e.g. the ULP test migrations, the Wald logpdf rewrite, and the fftpack package relocations were all confirmed as intentional and left untouched).

Note. This PR is intentionally a draft; a maintainer will audit and promote it.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written by Claude Code as part of an automated daily review of commits merged to develop; all fixes were cross-verified by multiple independent review passes before being applied.


Generated by Claude Code

@stdlib-bot

stdlib-bot commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
fft/base/fftpack $\\color{red}3674/5384$
$\\color{green}+0.00\\%$
$\\color{green}30/30$
$\\color{green}+0.00\\%$
$\\color{red}0/28$
$\\color{green}+0.00\\%$
$\\color{red}3674/5384$
$\\color{green}+0.00\\%$
fft/base/fftpack/ndarray $\\color{red}236/245$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{red}0/1$
$\\color{green}+0.00\\%$
$\\color{red}236/245$
$\\color{green}+0.00\\%$
fft/base/fftpack/ndarray/generic $\\color{red}185/194$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{red}0/1$
$\\color{green}+0.00\\%$
$\\color{red}185/194$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review August 21, 2026 00:24
@kgryte
kgryte requested a review from a team August 21, 2026 00:24
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 21, 2026
@kgryte kgryte changed the title fix: correct package name, annotations, and declarations in fft/base/fftpack namespaces chore: clean-up Aug 21, 2026
@kgryte
kgryte merged commit 0bb4e52 into develop Aug 21, 2026
31 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-08-20 branch August 21, 2026 00:28
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants