Repository navigation
fix: address off-by-one bug - #14352
Merged
Merged
Conversation
…neric/unary-strided1d/blocked` Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwN7AEABin3f7C1NSfUPWB
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 17, 2026 22:16
kgryte
approved these changes
Aug 17, 2026
ndarray/base/kernels/generic/unary-strided1d/blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-08-16 15:33 (-0700) (7d941afae) and 2026-08-17 04:59 (-0700) (0f459b6e5).This pull request:
ndarray/base/kernels/generic/unary-strided1d/blocked: FixresolveKernel()'s off-by-one range guard:MAX_DIMSwasKERNELS.length + 2(11) against aKERNELS[ndims-2]lookup covering ndims 2–10, soresolveKernel(11)fell through toundefinedinstead of thenulldocumented in the README, repl.txt, and@returnsannotation. Changed toKERNELS.length + 1(10) inlib/node_modules/@stdlib/ndarray/base/kernels/generic/unary-strided1d/blocked/lib/main.js:47(commit 0f459b6); re-verified resolveKernel(1)/(11)/(12) →nulland (2)…(10) → function.Related Issues
No.
Questions
No.
Other
Review scope: automated review of the 33 commits merged to
developin the 24 hours ending 2026-08-17 04:59 (-0700) (236 files, ~21k insertions): newblas/base/ndarraytriangular/packed wrappers (dtrmv/strmv/dtrsv/strsv/dspmv), newblas/ext/base/ndarray/{s,c,z}index-of-falsypackages, newndarray/basekernel infrastructure (offsets,set-descriptor-offsets,kernels/utils/increment-offsets,kernels/generic/unary-strided1d/blocked),math/base/special/{log2f,sincospif}, ULP-based test-assertion migrations, equation/docs regeneration, and namespace/TypeScript declaration catch-ups.Validation performed: style-guide compliance audit against
docs/style-guidesand established sibling reference packages; two independent bug scans of the full union diff, including runtime execution of the new blocked kernels (2d–10d boundary/coverage probes), BLAS wrapper example verification, and FreeBSD-reference checks of thelog2f/sincospifconstants and special cases. The fix above was independently identified by both bug scans and verified by execution before and after the change.Deliberately excluded: anything requiring interpretation or judgment (no subjective style preferences), and anything whose fix would touch code outside the reviewed diff window — e.g. namespace registration of the new
*index-of-falsypackages was left to the usual dedicatedfeat: add X to namespacefollow-up commits, and theblockedpackage's TypeScript declarations were not authored here since the siblingndarray/base/unary-strided1dpackage shares the same current state.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by a scheduled Claude Code review of the last 24 hours of commits merged to
develop: multiple independent AI review passes flagged candidate issues, each surviving issue was verified by direct code reading and runtime execution, and the one-line fix was authored and validated by Claude Code. A maintainer will audit before promoting from draft.Generated by Claude Code