Repository navigation
test: migrate math/base/special/bessely0 to ULP-based assertions - #14350
Merged
Merged
Conversation
Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 17, 2026
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/bessely0from relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomputation and they === expectedspecial case intest/test.jsandtest/test.native.jswith a singlet.strictEqual( isAlmostSameValue( y, expected[ i ], N ), true, 'returns expected value' );assertion.@stdlib/math/base/special/absrequire and adds@stdlib/assert/is-almost-same-value. The@stdlib/constants/float64/epsrequire is retained, asEPSis still used when generating negative inputs.ULP bounds (per fixture set, identical for
test/test.jsandtest/test.native.js):very_large_positive680.0 * EPS * abs( expected )1127large_positive2400.0 * EPS * abs( expected )3716medium_positive850.0 * EPS * abs( expected )1626small_positive1000.0 * EPS * abs( expected )1510smaller4.5 * EPS * abs( expected )7tiny_positive10.0 * EPS * abs( expected )2subnormal5000.0 * EPS * abs( expected )8678huge_positive4500.0 * EPS * abs( expected )4053positive_gamut16.0 * EPS * abs( expected )25These are the measured minima: each value above is the smallest integer for which the corresponding fixture set passes in full. I computed the exact ULP difference for every fixture point directly (via
@stdlib/number/float64/base/ulp-difference) rather than searching by trial and error, so the "next largest" column shows how much headroom each bound has over the runner-up point in its set. The JavaScript and native (C) implementations agree exactly on every fixture point (I built the native add-on locally withmake install-node-addons NODE_ADDONS_PATTERN="math/base/special/bessely0"and confirmed identical per-point ULP differences), so the same bounds apply to both test files.Only the two test files are changed; no source, documentation, or
package.jsonchanges are included.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
The
large_positive(3716),subnormal(8678), andhuge_positive(4053) bounds are large in absolute terms, but they are strictly tighter than the relative tolerances they replace and reflect the accuracy of the current rational-approximation implementation forY_0in these regimes. Happy to instead round these to a nearby convenient value if reviewers prefer some headroom over the measured minimum.Other
Verification performed locally:
make test TESTS_FILTER=".*/math/base/special/bessely0/.*"— 41653 passing, 0 failing.node test/test.jsandnode test/test.native.jsrun twice each at the final bounds with identical results (41653 passing both times), so the bounds are not sensitive to FMA/arch variation on this machine.test/test.native.jswas exercised against a locally built addon (make install-node-addons NODE_ADDONS_PATTERN="math/base/special/bessely0"), so the native assertions ran rather than being skipped.make lint-javascript-tests TESTS_FILTER=".*/math/base/special/bessely0/.*"— clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. The candidate discovery (scanning the whole repo for the old tolerance idiom, then checking existing ULP-migration PRs to avoid collisions), the test migration, and the ULP bound search (computing the exact per-point ULP difference directly, then confirming determinism via repeated runs) were performed by the agent, following the idiom established in already-migrated packages in
math/base/special— most directlymath/base/special/bessely1(#14344), converted just prior to this PR in the same Bessel-function family.@stdlib-js/reviewers
Generated by Claude Code